fix : 대결에 참여한 러너 중 기록이 없는 경우 별도 처리 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. RunningRecordCalculation에서 각 계산함수에 records의 empty 여부 판단 2. empty인 경우 스크린 다르게 처리
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
대결을 수행하자마자 바로 대결모드를 종료하면 기록이 존재하지 않게 된다.
그러나, 대결모드는 한 명이 나가더라도 방이 파괴되지 않으므로 나중에 기록을 조회할 때 기록이 없는 러너의 정보에 대한 처리가 반영되어야 한다.
Implementation
2023-10-16.10.45.53.mov