Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shared library builds (experimental) #1226

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JuliusNmn
Copy link

this patch fixes undefined symbol errors when building with -DBUILD_SHARED_LIBS=on.
building without the flag works too. only tested on macos.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #1226 (9fd02ec) into master (60ac82e) will not change coverage.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1226   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files         223      223           
  Lines       23667    23667           
=======================================
  Hits        15266    15266           
  Misses       8401     8401           

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant