Update ovh flavors #109
Closed
Update ovh flavors #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
reviewed
Oct 25, 2017
teuthology/openstack/__init__.py
Outdated
| if e.returncode == 1: | ||
| return None | ||
| else: | ||
| raise e |
There was a problem hiding this comment.
When it was just one line [1] being duplicated it wasn't a big deal. But now that you add this try..except block the amount of code being duplicated increases considerably. Can you split this out into a helper method to eliminate the code duplication?
[1] ips = json.loads(OpenStack().run("ip floating list -f json"))
smithfarm
approved these changes
Oct 25, 2017
kshtsk
force-pushed
the
wip-update-ovh-flavors
branch
3 times, most recently
from
1e8e42d to
3cc921b
Compare
Add s1 flavor to make teuthology working in new regions in OVH Add workaround for floating ip exception for some regions in OVH
kshtsk
force-pushed
the
wip-update-ovh-flavors
branch
from
3cc921b to
dd3a62d
Compare
smithfarm
reviewed
Mar 22, 2018
| @@ -454,7 +465,7 @@ def __flavor_wrapper(self, min, good, hint, arch): | |||
| select = None | |||
| if self.get_provider() == 'ovh': | |||
| log.debug("Looking for a match among the El Cheapo flavors...") | |||
| select = '^vps-ssd-' | |||
| select = '^(vps-ssd|s1)-' | |||
There was a problem hiding this comment.
@kshtsk Did you want to reverse the order here?
There was a problem hiding this comment.
@smithfarm yes... probably this can be implemented with ECP feature.
There was a problem hiding this comment.
@kshtsk Good idea. Then this PR could be closed.
|
#124 is covering this request |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add s1 flavor to make teuthology working in new regions in OVH
Add workaround for floating ip exception for some regions in OVH