Test clean for resubmission pipeline #1292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximenoel8
force-pushed
the
cleanup_pipeline
branch
3 times, most recently
from
2fed09e
to
18b49f5
Compare
maximenoel8
force-pushed
the
cleanup_pipeline
branch
from
7e75787
to
3371f7e
Compare
maximenoel8
force-pushed
the
cleanup_pipeline
branch
5 times, most recently
from
d64e530
to
cc2d8d4
Compare
maximenoel8
force-pushed
the
cleanup_pipeline
branch
11 times, most recently
from
b6c62a8
to
86ac92e
Compare
Save terraform state in resultdir.
maximenoel8
force-pushed
the
cleanup_pipeline
branch
from
86ac92e
to
f1bfbf7
Compare
maximenoel8
force-pushed
the
cleanup_pipeline
branch
2 times, most recently
from
bbddf5c
to
9dc36e5
Compare
maximenoel8
force-pushed
the
cleanup_pipeline
branch
from
9dc36e5
to
df15baa
Compare
| stage('Delete client VMs') { | ||
|
|
||
| // Construct the --tf-resources-to-delete argument dynamically | ||
| ArrayList tfResourcesToDelete = [] |
There was a problem hiding this comment.
Maybe we can reuse the lists at line 20 and 31.
|
|
||
| ## Prerequisites | ||
|
|
||
| - **Python 3**: Ensure Python 3 is installed. |
There was a problem hiding this comment.
I see we use Python 3.11 in CI.
Do we specifically need at least that version or will any (reasonably recent) Python 3.X be fine ?
| class ResourceManager: | ||
| def __init__(self, manager_url, resources_to_delete, product_version): | ||
| self.manager_url = manager_url | ||
| self.resources_to_delete = {"proxy", "monitoring", "build"} - set(resources_to_delete) |
There was a problem hiding this comment.
Is the naming off and the set difference are actually resources to protect ?
| if self.product_version == "uyuni": | ||
| channels = self.client.channel.listMyChannels(self.session_key) | ||
| for channel in channels: | ||
| if "custom" in channel['label'] and not any(protected in channel['label'] for protected in self.resources_to_delete): |
There was a problem hiding this comment.
Not strictly necessary and can always be done later on, as refactor/improvement.
We can probably have a private function to delete channels that takes a few parameters and replaces this code blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR ?
This PR gives the possibility to automatically handle the tools resubmission in the context of a release testing using BV.
In this PR there are two parts :
New cleanup pipeline ( for now 4.3 NUE and PRV )
What does this pipeline
Create a pipeline able to clean the server artifacts created during a BV run.
This pipeline will also redeploy the current clients using the new terracumber functionalities to modify a main.tf file.
What does NOT this pipeline
Adding or removing clients from the current deployment.
Redeploying monitoring and proxy.
New python scripts
SUSEManagerCleaner.py
Organize the modules and arguments.
suse_manager_api.py
Call the API ( from controller ) to clean the server artifacts.
suse_manager_ssh.py
Unfortunately, we require a ssh connection to server to remove the know hosts because the clients are fresh deployment.
Could be manage directly in groovy step if we don't want to add this python script.
Testing
Currently tested for debugging BV 4.3 NUE and PRV
Pipeline url : https://ci.suse.de/view/Manager/view/Manager-4.3/job/manager-4.3-qe-build-validation-NUE-cleaning/
What is missing ?
Issues
Related to: