Honor auto-import-gpg-keys flag on migration #271
Conversation
There was a problem hiding this comment.
lgtm 👍
How I reviewed this merge request:
- Checked the code for potential improvements I would suggest
- Ran a migration with enabled PackageHub from LTSS 15.3 and see it working
I saw it works fine also without --auto-import-gpg-key it will just interactively ask to import the key.
What I'm wondering the Bug sounds like they want it enabled by default and not only when you add --auto-import-gpg-key or?
Anyway, works fine for me
As always, if you think I missed something I should test, please let me know!🚀
cheer,s
The parsing of CLI arguments and how these are passed through the internal SCC client, zypper and other tools is not ideal and needs to be re-worked quite urgently. This is why other silly bugs have appeared in which we are not passing the correct arguments to our backend code. Until this rework is not done, let's simply apply this quick fix which simply passes the `--gpg-auto-import-keys` flag to the zypper backend when finding product packages. Fixes bsc#1231328 Signed-off-by: Miquel Sabaté Solà <[email protected]>
mssola
force-pushed
the
zypper-migration-bug
branch
from
ea91336
to
90f7981
Compare
I'm not exactly sure about that. To me it sounds like they are just trying to perform the migration and it failed on both Yast and |
Description
The parsing of CLI arguments and how these are passed through the internal SCC client, zypper and other tools is not ideal and needs to be re-worked quite urgently. This is why other silly bugs have appeared in which we are not passing the correct arguments to our backend code.
Until this rework is not done, let's simply apply this quick fix which simply passes the
--gpg-auto-import-keysflag to the zypper backend when finding product packages.Fixes bsc#1231328
How to test
I have manually tested this code, but I still have to do an end to end test which considers the exact path as described in bsc#1231328.