Grab the home directory from /etc/passwd if needed #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go's `os.UserHomeDir` has one big gotcha: it only fetches the value from the HOME environment variable and that's it: it does not try to fetch this value from anywhere else if that environment variable is not set. In some conditions (e.g. a systemd service file) this environment file might not be set and hence some important paths will not be properly generated. This commit ensures that the home directory is picked: if Go's `os.UserHomeDir` fails, then we will try to read this value from `/etc/passwd`. Fixes bsc#1226128 Signed-off-by: Miquel Sabaté Solà <[email protected]>
mssola
force-pushed
the
curlcredentialsnohome
branch
from
a9ba670
to
a36e56c
Compare
|
Feature tests seem temporarily broken (unrelated to this PR). I'll merge this PR and take a closer look at these tests later. |
|
Maybe this could be contributed upstream to Go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go's
os.UserHomeDirhas one big gotcha: it only fetches the value from the HOME environment variable and that's it: it does not try to fetch this value from anywhere else if that environment variable is not set.In some conditions (e.g. a systemd service file) this environment variable might not be set and hence some important paths will not be properly generated. This commit ensures that the home directory is picked: if Go's
os.UserHomeDirfails, then we will try to read this value from/etc/passwd.Fixes bsc#1226128