Temporarily hide the TypeOfService selector and allow empty values to…

… prevent unsubmittable forms Resolves #1321
SURFnet · Nov 27, 2024 · 097faf4 · 097faf4
1 parent a8db8ab
commit 097faf4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/assets/scss/pages/base.scss b/assets/scss/pages/base.scss
@@ -63,3 +63,7 @@
 .hidden {
   display: none;
 }
+
+div.form-row:has(#dashboard_bundle_entity_type_metadata_typeOfService) {
+  display: none;
+}
diff --git a/src/Surfnet/ServiceProviderDashboard/Application/Command/Entity/SaveOidcngEntityCommand.php b/src/Surfnet/ServiceProviderDashboard/Application/Command/Entity/SaveOidcngEntityCommand.php
@@ -157,9 +157,12 @@ class SaveOidcngEntityCommand implements SaveEntityCommandInterface
     #[Assert\Length(max: 300)]
     private $applicationUrl;
 
+    /**
+     * // phpcs:ignore
+     * `new Assert\NotBlank(),` TODO enable in https://github.com/SURFnet/sp-dashboard/issues/1322
+     */
     /** @var TypeOfService[] */
     #[Assert\All([
-        new Assert\NotBlank(),
         new Assert\Type(type: TypeOfService::class),
     ])]
     #[Assert\Count(

diff --git a/src/Surfnet/ServiceProviderDashboard/Application/Command/Entity/SaveSamlEntityCommand.php b/src/Surfnet/ServiceProviderDashboard/Application/Command/Entity/SaveSamlEntityCommand.php
@@ -110,9 +110,12 @@ class SaveSamlEntityCommand implements SaveEntityCommandInterface
     #[Assert\Length(max: 300)]
     private ?string $applicationUrl = null;
 
-    /** @var TypeOfService[] */
+    /**
+     * // phpcs:ignore
+     * `new Assert\NotBlank(),` TODO enable in https://github.com/SURFnet/sp-dashboard/issues/1322
+     * @var TypeOfService[]
+     */
     #[Assert\All([
-        new Assert\NotBlank(),
         new Assert\Type(type: TypeOfService::class),
     ])]
     #[Assert\Count(