Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THUB-15: Banner variants #13

Merged
merged 11 commits into from
Jul 9, 2024
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added dist/assets/banner-bg.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion dist/css/main.css

Large diffs are not rendered by default.

Binary file added src/assets/png/banner-bg.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/assets/png/banner-bg.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
124 changes: 124 additions & 0 deletions src/scss/components/banner/_overlay-banner.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
@charset "UTF-8";

.thub-wrapper--banner-overlay {
background: $su-color-black url("../assets/png/banner-bg.jpg") no-repeat 100% / cover;
rebeccahongsf marked this conversation as resolved.
Show resolved Hide resolved
rebeccahongsf marked this conversation as resolved.
Show resolved Hide resolved

.su-hero {
display: flex;
justify-content: flex-start;
flex-direction: column;

@include grid-media-min('lg') {
flex-direction: row;
}

// Border top? Need to figure out.
&::before {
background: $thub-gradient-lagunita-to-ochre-to-red;
height: 3px;
border-radius: 1.5px;
display: block;
content: ' ';
}
}

.su-hero__card {
max-width: 500px;
background: transparent;
border: none;
box-shadow: none;

section.su-card__contents {
color: $su-color-white;

div.su-card__superhead {
@include slab;

font-weight: $su-font-regular;
font-size: 1.7rem;
}

h2,
h3 {
@include thub-type-b;
}

p {
font-size: 2.1rem;
line-height: 1.5;

a {
@include thub-type-link;
}
}

a.su-link--action {
@include thub-type-link;
}
}
}

.su-hero__media {
right: 0;
width: fit-content;
min-height: 370px;
position: relative;

@include grid-media-min('md') {
// min-height: 768px;
}

@include grid-media-min('lg') {
position: absolute;
width: 50%;
// min-height: 717px;
}
}

// Left text
.overlay-left {
@include grid-media-max('md') {
.su-hero__card {
// left: 45px;
// margin-left: inherit;
// right: 45px;
}
}

.su-hero__card {
left: 3%;
max-width: calc(50% - 70px);

@include grid-media-max('md') {
max-width: calc(100% - 70px);
}
}
}

// Right text
.overlay-right {
.su-hero__media {
right: unset;
}

@include grid-media-max('md') {
.su-hero__card {
left: 45px;
margin-left: inherit;
right: 45px;
}
}

.su-hero__card {
right: 3%;
max-width: calc(50% - 70px);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline banner content appears to span outside of the viewport for 767px and smaller screens 👀

image

Copy link
Contributor Author

@jenbreese jenbreese Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebeccahongsf This issues appears to be fixed. Can you retry it?
EDIT:
Nope I had the wrong breakpoint. It is happening.


@include grid-media-max('md') {
max-width: calc(100% - 70px);
}
}
}
}



5 changes: 5 additions & 0 deletions src/scss/components/banner/index.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
@charset "UTF-8";

// Banner rollup file.

@import 'overlay-banner';
1 change: 1 addition & 0 deletions src/scss/components/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
// Components.
// @import 'component-name/index';

@import 'banner/index';
@import 'brand-bar/index';
@import 'card/index';
@import 'hero-banner/index';
Expand Down
22 changes: 22 additions & 0 deletions src/scss/utilities/mixins/_links.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
@charset "UTF-8";


@mixin thub-type-link {
color: $thub-color-ochre-light;
text-decoration: none;

&::after {
background-color: $thub-color-ochre-light;
}

&:hover,
&:focus,
&:active {
color: $su-color-white;
text-decoration: underline;

&::after {
background-color: $su-color-white;
}
}
}
1 change: 1 addition & 0 deletions src/scss/utilities/mixins/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@
@import 'cta';
@import 'headings';
@import 'link-icon';
@import 'links';
@import 'typography';
15 changes: 15 additions & 0 deletions taiwan_hub_subtheme.react_behaviors.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Example react_behaviors plugin definitions.
# Plugin property $defaults are defined in ReactBehaviorsPluginManager.
banner_variant_info: # part of the key after the :
id: banner_type
label: 'Banner Paragraphs Type'
bundles:
- paragraphs_type|stanford_banner
config:
banner_style:
type: select
title: 'Banner style'
description: Select the button color for displaying this banner.
options:
thub-wrapper--banner-default: Default variant
thub-wrapper--banner-overlay: Overlay variant
55 changes: 53 additions & 2 deletions taiwan_hub_subtheme.theme
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ function taiwan_hub_subtheme_theme_suggestions_block_alter(array &$suggestions,

function taiwan_hub_subtheme_preprocess_page(&$variables) {
$variables['add_curved_background'] = TRUE;

if(
isset($variables['node']) &&
isset($variables['node']) &&
$variables['node'] instanceof \Drupal\node\NodeInterface &&
$variables['node']->hasField('su_page_banner') &&
$variables['node']->get('su_page_banner')->count()
Expand All @@ -38,3 +38,54 @@ function taiwan_hub_subtheme_preprocess_page(&$variables) {
}
}
}

/**
* Implements hook_preprocess_HOOK().
*/
function taiwan_hub_subtheme_preprocess_ds_entity_view(&$variables) {
// if not running on a paragraph, exit out.
if (!isset($variables['content']['#paragraph'])) {
return;
}

$paragraph = $variables['content']['#paragraph'];

// Process Cards
if ($paragraph->bundle() == 'stanford_card') {
taiwan_hub_subtheme_preprocess_card($variables);
}

// Process Banners
if ($paragraph->bundle() == 'stanford_banner') {
taiwan_hub_subtheme_preprocess_banner($variables);
}
}


/**
* Implements hook_preprocess_card().
*/
function taiwan_hub_subtheme_preprocess_card(&$variables) {

$paragraph = $variables['content']['#paragraph'];

// Add border style class to card wrapper.
$variables['attributes']['class'][] = $paragraph->getBehaviorSetting('react_paragraphs:card_variant_info', 'card_border_style', 'su-card-wrapper--border-regular');

$card_info = [];

// Add card type class to card wrapper. 3rd variable provides the default card type.
$card_info['card_type'] = $paragraph->getBehaviorSetting('react_paragraphs:card_variant_info', 'card_type', 'su-card-wrapper--default');
$variables['attributes']['class'][] = $card_info['card_type'];
}

/**
* Implements hook_preprocess_banner().
*/
function taiwan_hub_subtheme_preprocess_banner(&$variables) {

$paragraph = $variables['content']['#paragraph'];

// Add button color style class to card wrapper.
$variables['attributes']['class'][] = $paragraph->getBehaviorSetting('react_paragraphs:banner_variant_info', 'banner_style', 'thub-wrapper--banner-default');
}
Loading