Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THUB-29: local footer tweaks #11

Merged
merged 2 commits into from
Jul 1, 2024
Merged

THUB-29: local footer tweaks #11

merged 2 commits into from
Jul 1, 2024

Conversation

jenbreese
Copy link
Contributor

READY FOR REVIEW

Summary

  • Minor edits to the local footer.

Review By (Date)

  • 6/30

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add content to local footer as in the designs. Figma link is in the ticket.
  3. Verify the spacing is changed per requested in ticket.
  4. Check responsive for no weirdness.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- THUB-29

Resources

Copy link

@rebeccahongsf rebeccahongsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thank you @jenbreese!

@jenbreese jenbreese merged commit 2e89993 into 1.x Jul 1, 2024
1 check passed
@jenbreese jenbreese deleted the THUB-29--footer-tweaks branch July 1, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants