Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUM-260: adding a tooltip #81

Closed
wants to merge 3 commits into from
Closed

SUM-260: adding a tooltip #81

wants to merge 3 commits into from

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Dec 18, 2024

NOT READY FOR REVIEW

  • This really isn't ready for code review. @pookmish can you give me some feedback on how to improve it? There is a React error I haven't figure out yet too.

Summary

  • TL;DR - what's this PR for?

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Urgency

  • How urgent is this? (Normal, High)

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to...
  4. Verify...

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SUM-260

Resources

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
summer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 4:49am

Copy link
Contributor

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way you are going about this is much more complex than needs to be. take a look at react-toastify to see if it will do the work you are looking for.

Also, it's highly discouraged to ever put a component inside a function. Not to mention you can't have a hook like useState inside a function. I strongly recommend going through some react trainings for hooks and components. Some possible resources:

@jenbreese
Copy link
Contributor Author

I'm closing this because I'm redoing it.

@jenbreese jenbreese closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants