SUM-262 SUM-264 SUM-266: fixes to the 4px white border

[jenbreese]

NOT READY FOR REVIEW

Summary

• Added a 4px white border bottom to the image banners
• Added a 4px white border bottom to the testimonial banners
• Added a 4px white border around the top grey header.
• Added a 4px white border around the default grey image card for lg and up sizes.

Review By (Date)

• when time allows

Criticality

• Normal

Urgency

• Normal

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. On a page, add several stacked image banners and verify there is a 4px margin top between them.
3. On a page, add several stacked testimonial banners and verify there is a 4px margin top between them.
4. Verify the top grey header has a 4px white border around the whole thing.
5. On this page, /students/undergraduate-students, Verify the grey cards have a 4px white border.

Site Configuration Sync

• Is there a config:export in this PR that changes the config sync directory?

Front End Validation

• Design is approved by @ user?
• HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
• Cross-browser testing: Has been performed? Or, QA request ticket created?
• Automated accessibility: Scans performed? Or, QA request ticket created?
• Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SUM-262
- SUM-264
- SUM-265
- SUM-266
- SUM-267

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
summer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 20, 2024 7:38pm

[pookmish]

Is the border in the header correct? it feels out of place with the global message there

[jenbreese]

Thanks for the catch. I'll check in with design.

[jenbreese]

@pookmish Yes Design had envisioned something else. I'll rework this tomorrow.