SUM-290: Replace "Hidden" class with "tw-hidden"

[jenbreese]

READY FOR REVIEW

Summary

• Removed hidden to keep Apply Now and Request info buttons from disappearing.
• The clients want the buttons to always be present according to the ticket.

Review By (Date)

• 11/22

Criticality

• High

Urgency

• High

Review Tasks

Setup tasks and/or behavior to test

1. Check out this gitpod
2. Navigate to a page
3. Verify the two buttons stay and don't disappear.

Site Configuration Sync

• Is there a config:export in this PR that changes the config sync directory?

Front End Validation

• Design is approved by @ user?
• HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
• Cross-browser testing: Has been performed? Or, QA request ticket created?
• Automated accessibility: Scans performed? Or, QA request ticket created?
• Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SUM-290

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
summer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 21, 2024 4:58pm

[rebeccahongsf]

Huzzah! It works 🎉 Thank you, @jenbreese

[rebeccahongsf]

@pookmish is this something we can merge right into 1.x? 🤔
I have yet to get up to speed on how we plan to handle summer releases. Thank you for your support on this in advance!

[pookmish]

The production site is using the main branch. when a commit/merge is pushed to the 1.x branch, there's an automated task that will update the dev and test branches. To deploy a change to production, we have to merge the 1.x into main using git checkout main && git merge 1.x

I'm going to add a eslint rule to check for these hidden classes.

[pookmish]

@jenbreese it looks like there is one more use of the hidden class on the component in src/components/layouts/interior-page.tsx

Also it's worth mentioning that responsive classes for hidden aren't impacted. things like lg:hidden still work normally because the Slate uses a style like this:

.hidden {display:none !important}

so if we use a responsive class, the class name doesn't match .hidden selector.

[jenbreese]

@pookmish Thank you. I updated the hidden you found. It was on the skip secondary navigation link.