Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUL23-609: fix to text in hours card on homepage #209

Merged
merged 2 commits into from
Aug 29, 2024
Merged

SUL23-609: fix to text in hours card on homepage #209

merged 2 commits into from
Aug 29, 2024

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Aug 28, 2024 •
edited
Loading

READY FOR REVIEW

Summary

  • changed the padding-bottom on the hours card on the hompage

Review By (Date)

  • 8/29

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Navigate to https://su-library-git-sul23-609-hours-spacing-stanford-libraries.vercel.app/
  2. Verify text in card does not run off the card in responsive sizes.
  3. Try different libraries to see how it wraps in the select.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SUL23-609

Resources

@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
su-library ✅ Ready (Inspect) Visit Preview Aug 28, 2024 10:11pm

@jenbreese jenbreese requested a review from pookmish August 28, 2024 22:00
pookmish
pookmish requested changes Aug 28, 2024
View reviewed changes
src/components/node/stanford-page/home-page/today-hours.tsx Outdated
@@ -63,7 +63,7 @@ const LibrariesTodayHours = ({libraries, ...props}: {libraries: HoursProps["libr
)
}
footer={
<div className="relative pb-100 md:rs-pb-7">
<div className="relative pb-[14rem] md:rs-pb-8">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pb-140 would do the same thing. As much as we can use regular TW classes, the better.

@pookmish pookmish merged commit 4593780 into 1.x Aug 29, 2024
5 checks passed
@pookmish pookmish deleted the SUL23-609--hours-spacing branch August 29, 2024 20:02
imonroe added a commit that referenced this pull request Sep 11, 2024
@imonroe @pookmish @jenbreese
Release 1.4.0 (#215)
7aed6ac 
* SUL23-540: Updated robots.txt to disallow /all/ (#166)

* Better automated tests & Gitpod by building a cloned site (#165)

* Remove node cache to improve cache invalidation for config pages (#168)

* SUL23-515 SUL23-541: Colors, fonts, word fixes to the toggles. (#169)

* SUL23-515 SUL23-541: Colors, fonts, word fixes to the toggles.

* Keyword search filter stubbed out (#156)

* Keyword search filter stubbed out

* SUL23-503: fixup to search box styles

* fixup to styles

* moved over the search cursor

* Fix label

* fixup to the button toggles

---------

Co-authored-by: Jen Breese-Kauth <[email protected]>

* SUL23-525: Updates to the display for Med breakpoint on Branches and Centers (#170)

* SUL23-525: stashing work.

* SUL23-525: using grid to get alignment and display for md view

* Changed three tabular layouts to use the grid at the md breakpoint

* fixup to comment

* SUL23-438: Moved the location link and changed to Open or Closed until (#163)

Co-authored-by: Mike Decker <[email protected]>

* SUL23-479: added space (#176)

* SUL23-549: places to study alignment (#172)

* SUL23-549: places to study alignment

* SUL23-570: adding the corrected times to the places to study table (#175)

* SUL23-550: Move the condition so the td element remained even when empty (#171)

* SUL23-550: Move the condition so the td elmement remained even when empty

* fixup

* SUL23-548 SUL23-553 SUL23-554 SUL23-555 SUL23-556 SUL23-547 (#173)

* SUL23-548 SUL23-553 SUL23-554 SUL23-555 SUL23-556 SUL23-547

* fixup

* fixup

* fixup

* SUL23-543: rounded corner

* SUL23-557: adding aria-hidden and tabindex for a11y to photos on tabular data tables (#177)

* SUL23-557: stashing work to ask about tomorrow

* SUL23-557: fixup for the tabindex

* fixup to branch  page

* SUL23-557: removed the link on the image in the study places

* Adjust how library hours data is cached to reduce cache writes/reads (#178)

* SUL23-503: search label font size (#180)

* SUL23-570: changed address to size 16 (#179)

* SUL23-580: nav fixup (#184)

* SUL23-556: normal font and leading (#186)

* SUL23-503 Add text reset button and no results display (#185)

* SUL23-503 Add text reset button and no results display

* SUL23-503: changed size, added padding and color

* fixup after merge

---------

Co-authored-by: Jen Breese-Kauth <[email protected]>
Co-authored-by: Ian Monroe <[email protected]>

* SUL23-577 SUL23-586: buttons and vertical centering on tables (#183)

* SUL23-577 SUL23-586: buttons and vertical centering on tables

* fixed the col spacing

---------

Co-authored-by: Ian Monroe <[email protected]>

* SUL23-576 SUL23-575 SUL23-574: fixed height of toggle and filters (#182)

* SUL23-576 SUL23-575 SUL23-574: fixed height of toggle and filters

* fixup to corner

* SUL23-576: fixup

* removed rounded idea

* SUL23-591: added the th row=scope for a11y (#187)

Co-authored-by: Ian Monroe <[email protected]>

* Fix date formatting when the input is UTC

* SUL23-551: sentence case for branches and places to study (#188)

* SUL23-551: sentence case for branches and places to study

* Sentence case for all locations

* SUL23-482: set Todays hours title to h2 (#189)

* SUL23-482: set Todays hours title to h2

* "Hours" needed to be sentence case

* SUL23-587 SUL23-589 SUL23-590 (#190)

* SUL23-587 SUL23-589 SUL23-590

* adding the correct padding after cell

* SUL23-588: make the hover hug the phone and email

* Moved to just lg for inline flex

* fixup

* SUL23-578: fixup to the margin-bottom and casing (#191)

* SUL23-578: fixup to the margin-bottom and casing

* adding the flex change from the parent branch

* Fix date formatting when the input is UTC

* SUL23-578: added the 2 digits to the closed until time and lowercase of until

* fixup to the AM PM

---------

Co-authored-by: Mike Decker <[email protected]>

---------

Co-authored-by: Mike Decker <[email protected]>

* SUL23-577: fixed button height. removed include not used (#192)

* SUL23-587: updates to the people table (#193)

* SUL23-587: updates to the people table

* SUL23-440 Add "Load More" button on news lists over 30 items

* Added missing fields for people teasers

* SUL23-440 Adjusted "Load More" to "Load more"

* SUL23-597 Fix "today" vs "tomorrow" vs "friday" next opening day

* SUL23-597 Fix hour displays for next open date/time (#194)

* Removed "Hours this week" text

* SUL23-598: fixup up hover on branch name (#195)

* SUL23-598: fixup up hover on branch name

* fixup

* SUL23-574: setting exact height (#196)

* SUL23-580 SUL23-538: Added in the at to the time string (#197)

* Handle empty response from api/library-hours if something fails

* SUL23-585: Adding Donate now button to header (#198)

* SUL23-585: Adding Donate now button to header

* SUL23-585: button in header

* fixup

* changed Links to links

* SUL23-585: Back to digital red (#201)

* SUL23-571 Sort library options by title

* SUL23-600 show closing minutes if they are not 00 (#202)

* SUL-23-570: adding Hours this week for default (#203)

* SUL23-603: removed padding-left on branch name (#205)

* SUL23-604: tweaking the toggle spacing (#206)

* SUL23-573: tightening up spacing (#199)

* SUL23-573: tightening up spacing

* fixup

* fixup for the hover on email and phone

* fixup

* adjusting the top and bottom spacing and removed empty spacers

* fixup

* SUL23-608: changed the padding-left when the browser size is smaller (#207)

* fixup for the extra space

* fixup

* SUL23-605: fine tuning the sul people page. (#204)

* SUL23-605: fine tuning

* src/

* asking for feedback

* Fix on click handlers

* fixup to the group classes

* adding hover and active

* Added checkmark visual indicator

---------

Co-authored-by: Mike Decker <[email protected]>

* SUL23-601: changed when focused to not be red with red underline (#208)

* SUL23-601: changed when focused to not be red with red underline

* fixup

* SUL23-601: fixed the All to All specialists per slack rquest.

* SUL23-609: fix to text in hours card on homepage (#209)

* SUL23-609: fix to text in hours card on homepage

* fixup

* Sul23 611  Improve and simplify toggles (#210)

* Add a clear cache button for preview environments

* SUL23-610 add SDR as an oembed provider in the wysiwyg

* Sul23 611  tweaks (#211)

* SUL23-611: draft work for spacing on small screens

* adjustments to the focus and toggles

* tweaks

* tweaks

* fixup

* fixup

* fixup

* fixup

* Removed old eslint file

* SUL23-614 SUL23-615: fixes for html validation (#213)

* SUL23-615: footer link size (#212)

* SUL23-617: changed to Expertise (#214)

* Updated changelog

---------

Co-authored-by: pookmish <[email protected]>
Co-authored-by: Jen Breese <[email protected]>
Co-authored-by: Mike Decker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pookmish pookmish pookmish approved these changes

Assignees

@pookmish pookmish

Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenbreese @pookmish