Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUL23-549: places to study alignment #172

Merged
merged 5 commits into from
Jul 22, 2024
Merged

SUL23-549: places to study alignment #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2188a0
SUL23-549: places to study alignment
jenbreese Jul 18, 2024
73cf2b8
Merge branch '1.x' into SUL23-549--study
jenbreese Jul 18, 2024
47eb268
fixup
jenbreese Jul 18, 2024
1129d44
fixup
jenbreese Jul 18, 2024
af7406f
fixup
jenbreese Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...omponents/views/sul-branch-locations/filtering-table/branch-locations-filtering-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ const TableRow = ({id, imageUrl, path, title, phone, email, mapUrl, address, hou
className="block sm:flex-col sm:flex-wrap sm:text-center md:grid md:grid-cols-2 md:grid-rows-[repeat(4,minmax(0,auto))] md:justify-items-start md:gap-x-20 md:text-left md:align-top lg:!table-row lg:max-h-none"
>
<Td className="table-image m-auto flex min-h-fit w-auto place-content-center justify-center sm:border-b sm:border-black-40 md:row-span-4 lg:mr-25 lg:table-cell lg:w-[125px] lg:align-middle">
<div className="relative block aspect-[3/2] w-[338px] overflow-hidden lg:w-[125px]">
<div className="relative block aspect-[3/2] w-auto max-w-[338px] overflow-hidden md:w-[290px] lg:max-w-[125px]">
{imageUrl && (
<Image
className="object-contain"
Expand Down
4 changes: 2 additions & 2 deletions src/components/views/sul-people/sul-people-table-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ const SulPeopleTableView = ({items, hasHeading}: Props) => {
/>
<span className="block rounded-l-full border-r-0 border-transparent p-10 px-20 text-19 underline group-hover:no-underline peer-checked:bg-[#979694] peer-checked:bg-opacity-20 peer-focus:border-2 peer-focus:border-black-80 peer-focus:bg-[#979694] peer-focus:bg-opacity-10">All specialists</span>
</label>
<label className="group cursor-pointer border-l border-black-80">
<label className="group cursor-pointer border-black-80 lg:border-l">
<input
type="checkbox"
className="peer sr-only"
Expand All @@ -128,7 +128,7 @@ const SulPeopleTableView = ({items, hasHeading}: Props) => {
</fieldset>
</div>
</form>
<Table className="responsive-table responsive-table-study text-center md:text-left">
<Table className="responsive-table text-center md:text-left">
<caption
className="sr-only"
aria-live="polite"
Expand Down
4 changes: 2 additions & 2 deletions src/components/views/sul-study-place/filtering-table/study-place-filtering-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ const StudyPlaceFilteringTable = ({items}: Props) => {
Library
</Th>
<Th
className="type-1 block pl-[0px] text-center md:table-cell md:text-left"
className="type-1 block pl-[0px] text-center md:table-cell md:text-left lg:text-center"
scope="col"
>
Open/Closed
Expand Down Expand Up @@ -220,7 +220,7 @@ const StudyPlaceFilteringTable = ({items}: Props) => {
{item.branchImageUrl && (
<Link
href={item.branchPath}
className="relative block aspect-[3/2] w-[338px] overflow-hidden lg:min-w-[125px]"
className="relative block aspect-[3/2] w-auto max-w-[338px] overflow-hidden md:w-[290px] lg:max-w-[125px]"
aria-labelledby={item.id}
>
<Image
Expand Down
2 changes: 1 addition & 1 deletion src/components/views/sul-study-place/filtering-table/study-place-today-hours-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const StudyPlaceHoursComponent = ({hoursId}: {hoursId: string}) => {
const hoursDisplay = closedAllDay ? "Closed" : isOpen ? closingTime : afterClose ? closingTime : openingTime

return (
<div className="type-0 centered mb-20 text-black-true">
<div className="type-0 centered text-black-true">
<div
aria-live="polite"
className="text-left lg:text-center"
Expand Down
12 changes: 11 additions & 1 deletion src/styles/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,22 @@
padding-left: 0 !important;
text-align: unset !important;
}
@media screen and (max-width: 55.29em) {
.responsive-table tr td.pivoted {
padding-top: 0 !important;
padding-bottom: 16px !important;
}
.responsive-table tr td.pivoted:first-of-type {
padding-top: 16px !important;
}
}
.responsive-table ul li:last-child span {
display: none;
}

@media screen and (max-width: 40em) {
.responsiveTable.responsive-table-study td.table-image {
.responsiveTable.responsive-table-study td.table-image,
.responsiveTable.responsive-table-branches td.table-image {
display: block;
}
}
Expand Down
Loading