SHS-5811: Add "logout" button to sites

[codechefmarc]

READY FOR REVIEW

Summary

• Adds a separate logout block

Review By (Date)

2024-10-07

Criticality

• How critical is this PR on a 1-10 scale? 3

Urgency

• Low

Review Tasks

Setup tasks and/or behavior to test

1. Full testing environment located here: SHS-5811: Add logout button to sites SU-HSDO/suhumsci#1641

Steps to Test

2. Login to the site as an admin
3. Visit the Block layout page Block page: /admin/structure/block
4. Click "Place block" in the footer region
5. Choose the "SAML SUNetID Logout Block"
6. Do not display the title, then click "Save Block"

7. Verify on the front-end, while logged in, that there is now a logout button

8. Click o the logout button and verify that it correctly logs you out of the site

Site Configuration Sync

• Is there a config:export in this PR that changes the config sync directory?
• No

Front End Validation

• Design is approved by @ user?
• HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
• Cross-browser testing: Has been performed? Or, QA request ticket created?
• Automated accessibility: Scans performed? Or, QA request ticket created?
• Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

• JIRA ticket(s)
• Other PRs
• Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
• Anyone who should be notified? (@mention them here)

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[codechefmarc]

I've split the logout block into its own plugin and reverted the changes in the login block plugin. Ready for review.

[codechefmarc]

@pookmish - this is ready for a re-review. I've added a separate logout block and added a test for the new block. Thank you!

[pookmish]

Works as described. Please revert the composer.json and I'll merge it in.

[codechefmarc]

Okay, reverted, ready to go.

[pookmish]

Thanks @codechefmarc , FWIW, you shouldn't need to change the composer even in a forked repo. If you designate the VCS repository in the stack composer, it should use that instead of the packagist one. We've done that to fork drupal.org modules a couple times when upgrading to D9