Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7652: font size and spacing adjustments #352

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Nov 21, 2024

READY FOR REVIEW

Summary

  • Adjusting font size
  • Adjusting line-height for name and title
  • Adjusting spacing under the photo to 0

Review By (Date)

  • When time allows it is for v5.x.y

Criticality

  • normal

Urgency

  • normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this Gitpod
  2. Make sure you have people content
  3. Navigate to /people and a filtered person
  4. Verify the h3 is smaller, the line-height changed and the padding-bottom is 0 on the photo
  5. Verify no change to the person node or to the person teaser

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-7652

Resources

@pookmish pookmish merged commit 103ec2a into 9.x Dec 19, 2024
6 of 9 checks passed
@pookmish pookmish deleted the D8CORE-7652--people-adjustments branch December 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants