Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7533: Adding 2 more quote styles #348

Merged
merged 6 commits into from
Dec 19, 2024
Merged

D8CORE-7533: Adding 2 more quote styles #348

merged 6 commits into from
Dec 19, 2024

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Nov 19, 2024

READY FOR REVIEW

  • The ticket has been updated with Figma and a screenshot.

Summary

  • Added 2 new quote styles
  • Adjusted the styling for all three quote styles.
  • Quote is centered.

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Import the config change
  3. Rebuild Cache and import config drush cr ; drush ci
  4. Navigate to a page and create the three different quotes.
  5. Verify they look like the design in the ticket.
  6. Verify they change as expected when the browser window changes size

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory? YES

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-7533

Resources

@github-actions github-actions bot added the patch label Dec 13, 2024
@jenbreese jenbreese changed the title D8CORE-7533: saving work while ironing out questions D8CORE-7533: Adding 2 more quote styles Dec 13, 2024
@jenbreese jenbreese requested a review from pookmish December 13, 2024 18:31
@pookmish pookmish merged commit 879ada2 into 9.x Dec 19, 2024
6 of 9 checks passed
@pookmish pookmish deleted the D8CORE-7533--quotes branch December 19, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants