Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7568: moved margin bottom on news article #338

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Oct 23, 2024

READY FOR REVIEW

Summary

  • Moved the margin-bottom on the news sharing icons to a margin-top on the news banner.
  • Reduced the space to a ms-6 from a ms-7

Review By (Date)

  • 10/26

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to a news page with with a banner
  3. Verify margin-top instead of margin-bottom on social media.
  4. Navigate to a news page without with a banner.
  5. Verify there is still space between the icons and top of article.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-7568

Resources

@jenbreese
Copy link
Contributor Author

Hi @pookmish The tests are ok now, excluding the Drupal 11 ones. Will you let me know what you think? Thank you!

@pookmish pookmish merged commit eb1f6e0 into 9.x Nov 1, 2024
6 of 9 checks passed
@pookmish pookmish deleted the D8CORE-7568--news-padding branch November 1, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants