Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cap URL to a source plugin #312

Open
wants to merge 2 commits into
base: 9.x
Choose a base branch
from
Open

Move cap URL to a source plugin #312

wants to merge 2 commits into from

Conversation

pookmish
Copy link
Contributor

@pookmish pookmish commented Apr 25, 2024 •
edited
Loading

READY FOR REVIEW

Summary

  • Replace the config overrides that fetch the paged urls with a migrate source plugin. This avoids unnecessarily calling the API just to load the configs.

Review Tasks

  1. Checkout this branch
  2. config the person importer with a workgroup/org code that has over 15 profiles, our groups have more than 15.
  3. run the importer (may need a cache clear first)
  4. verify all profiles were imported.

@pookmish pookmish requested a review from joegl April 25, 2024 21:35
@pookmish pookmish force-pushed the cap-url-source-plugin branch from f4194af to 304a8d8 Compare May 28, 2024 22:39
@github-actions github-actions bot added size/m and removed size/s labels May 28, 2024
@pookmish pookmish marked this pull request as ready for review May 29, 2024 15:33
@pookmish
Copy link
Contributor Author

gentle poke. no rush at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joegl joegl Awaiting requested review from joegl

Assignees

@joegl joegl

Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pookmish @joegl