D8CORE-7189 | @jdwjdwjdw | Update splash font card headline margin-bottom #299

jdwjdwjdw · 2024-03-07T20:48:07Z

READY FOR REVIEW

D8CORE-7189: As a site editor, I need to be able to control the heading structure on a Card Paragraph in my page content to make sure the information has proper hierarchy.
- Updates after designer QA comments in this ticket. Per our related discussion in stand-up, our decision was to address the splash font card headline margin-bottom (design recommended MS(-1)), and leave the other suggestions as is for now.
- I had to add some additional specificity in order to overwrite conflicting decanter styles for the splash font card headline margin-bottom.

Check out this branch
Add example cards and banners with the splash font headline style selected. Confirm that the updated margin-bottom is being applied.
Review code 🏖️

D8CORE-7189: As a site editor, I need to be able to control the heading structure on a Card Paragraph in my page content to make sure the information has proper hierarchy.

pookmish · 2024-03-07T21:13:01Z

modules/stanford_profile_styles/lib/scss/component/paragraph/card/_card.scss

+    >div {
+      &:not(.su-card__button) {
+        &.su-font-splash {


this kinda annoys me with our current codeclimate settings.

What issues does this cause related to our codeclimate settings? Just curious.

Update splash font card headline margin-bottom

3da9357

jdwjdwjdw requested a review from pookmish March 7, 2024 20:48

jdwjdwjdw assigned pookmish Mar 7, 2024

github-actions bot added the size/xs label Mar 7, 2024

Fixup

b5a66f6

pookmish reviewed Mar 7, 2024

View reviewed changes

pookmish approved these changes Mar 7, 2024

View reviewed changes

pookmish merged commit f42d6ac into 9.x Mar 7, 2024
6 checks passed

pookmish deleted the D8CORE-7189--card-splash-text-margin-bottom branch March 7, 2024 21:18