Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7212 | @jdwjdwjdw | Update "Teaser" paragraph type styles #298

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Feb 28, 2024

READY FOR REVIEW

Summary

  • D8CORE-7212: DEV | Update "Teaser" paragraph type
  • D8CORE-7198: As a non-sighted visitor, I don't have proper understanding of items displayed under Teaser Paragraph with a headline because the heading structure is off and article titles are not unique.
    • Updated teaser styles based on the requirements in this ticket: Card <h3> should display in font-size: 1.40em

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add a basic page and add a teaser paragraph type with a headline, as well as one without a headline. Add teasers from each content type
  3. Confirm that for the teaser paragraph without a headline, the individual teaser h2's have been updated to h3, and the required h3 font-size has been updated to 1.4em
  4. Review code 🍫

Associated Issues and/or People

  • D8CORE-7212: DEV | Update "Teaser" paragraph type
  • D8CORE-7198: As a non-sighted visitor, I don't have proper understanding of items displayed under Teaser Paragraph with a headline because the heading structure is off and article titles are not unique.

@pookmish pookmish force-pushed the D8CORE-7212--teaser-styles branch from 187c6a5 to 541b35b Compare February 28, 2024 20:26
@pookmish pookmish merged commit 86123cd into D8CORE-7212 Feb 28, 2024
4 checks passed
@pookmish pookmish deleted the D8CORE-7212--teaser-styles branch February 28, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants