Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-5952: removed pipe from past events on node page #273

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

jenbreese
Copy link
Contributor

READY FOR REVIEW

Summary

  • Removed the | (pipe) on Past Events node page

Review By (Date)

  • When time allows

Criticality

  • normal

Urgency

  • normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to a site and create Events that were in the past
  4. Verify there is no pipe after the Past Event with nothing after it
  5. Verify there is a pipe on the past events list

Screenshot 2023-09-27 at 3 09 05 PM
Screenshot 2023-09-27 at 3 08 37 PM

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-5952

Resources

Copy link
Contributor

@jdwjdwjdw jdwjdwjdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jenbreese!

@jenbreese
Copy link
Contributor Author

@pookmish This was approved. I was wondering if it ok to merge.

@pookmish pookmish merged commit 3d79fe7 into 9.x Oct 3, 2023
@pookmish pookmish deleted the D8CORE-5952--past-events branch October 3, 2023 18:39
pookmish added a commit that referenced this pull request Oct 20, 2023
- D8CORE-6976: updating the Decanter version (#278)
- Adjust intranet roles when deleting roles
- Update layout paragraphs node grid (#276)
- D8CORE-6968 Fix gap and update all webpack setups (#275)
- D8CORE-6715 Better hiding of list paragraph (#274)
- D8CORE-5952: removed pipe from past events on node page (#273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants