Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7564: removed decanter link and replaced with identity guide #822

Merged

Conversation

buttonwillowsix
Copy link
Contributor

NOT READY FOR REVIEW

Summary

  • Remove broken link in Lockup Settings and Appearance settings for Stanford Basic

Review By (Date)

  • next release, but not super high priority. Looks janky.

Criticality

  • How critical is this PR on a 1-10 scale: 1

Urgency

  • Normal.

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Go to Lockup Settings and verify that help text looks OK
  3. Go to Stanford Basic Appearance settings and verify that help text looks OK

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

No front-end impact.

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@buttonwillowsix
Copy link
Contributor Author

Low priority: do we want to swap out the image /admin/appearance/settings/stanford_basic with the same one as exists in Lockup Settings.

@pookmish pookmish merged commit 6e85c3f into 11.x Oct 16, 2024
6 of 9 checks passed
@pookmish pookmish deleted the D8CORE-7564-remove-link-to-decanter-in-the-lockup-settings branch October 16, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants