-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D8CORE-5741: Opportunities Feature #801
Conversation
@@ -0,0 +1,28 @@ | |||
uuid: 6bd22067-d9e5-43ac-9206-6c511941d713 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to find a better solution than 10 separate taxonomies. It makes is very difficult to do much with it and it's very difficult for content editors to know which taxonomy they need to edit.
My idea is to use a single vocabulary that is multiple levels. The top most level is the "Label" and the children will be treated like the field values. I'll have to look to see if there is any contib module for the form UI, but I could probably build one that could do that as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@buttonwillowsix what do you think about this behavior? I've got an approach where the field form is built by the taxonomy hierarchy. The parent terms are treated like the field labels, and then a user can structure their content as they see fit. If they need 2 categories, they just create 2 parent terms. If they need 20, they create 20 parent terms. There's really no limitation to the number of vocabularies with this approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pookmish. I love this approach. MUCH better.
Not that this should stop us, but do you think it would be possible to migrate cardinal service vocabs (which is what is driving this insane list) into that model?
So, to accept this PR, would I just trim it down to a single "Tags" vocab? I will make that change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pookmish I trimmed this down. Please have a look!
I also changed Course Code to allow multiple entries since there will be cross-listings for some.
2b9c8b0
to
379d2ef
Compare
READY FOR REVIEW
Summary
This includes the following items for an Opportunity content type
Review By (Date)
Criticality
Urgency
Review Tasks
Setup tasks and/or behavior to test
Site Configuration Sync
Front End Validation
No front-end work here!
Backend / Functional Validation
Code
Code security
Affected Projects or Products
Associated Issues and/or People
Resources