Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7414: Different sorting option for Basic Page lists #791

Merged
merged 1 commit into from
May 16, 2024

Conversation

buttonwillowsix
Copy link
Contributor

@buttonwillowsix buttonwillowsix commented May 14, 2024

READY FOR REVIEW

Summary

  • "I want to sort the information pages I have tagged by their creation date" -- said no one ever. This creates a card grid view sorted by page title.

Review By (Date)

  • No rush. But it would be lovely to have.

Criticality

  • Non-critical

Urgency

  • None.

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Make some basic pages tagged with some terms
  3. Create a list paragraph and select Card Grid, Alpha Title Sort (asc)
  4. Verify the pages are in alpha order
  5. Select Card Grid, Creation Date Sort (desc) to confirm we didn't screw up the existing behavior

Questions/Feedback needed:

  • I was unable to test Basic Page lists on Gitpod (weird!)
  • I am thinking about naming conventions if we allow other sorting options. I might revise this PR if better terminology occurs to me, or I see something in the wild that is better.

Site Configuration Sync

  • Yes. One file.

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • D8CORE-7414
  • Issue in Advancing Democracy where we are doing the sort by hand

Resources

@buttonwillowsix
Copy link
Contributor Author

Somewhat impossible to test. For some reason Basic Page lists are empty on GitPod....

@buttonwillowsix buttonwillowsix requested a review from pookmish May 15, 2024 00:18
Copy link
Contributor

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. Can you create a ticket to write a test for this though

@pookmish pookmish merged commit bfd1cee into 11.x May 16, 2024
6 checks passed
@pookmish pookmish deleted the D8CORE-7414-dev-sorting-option-for-basic-page-lists branch May 16, 2024 18:16
@buttonwillowsix
Copy link
Contributor Author

Yes! I will make a ticket. And WOOOOO! So exciting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants