Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7212 Use h3 header for cards in teasers when appropriate' #765

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

pookmish
Copy link
Contributor

  • D8CORE-7212 Add h3 card display mode and configure for each content type
  • Started acceptance test
  • Update course and event card configs

NOT READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

  • TL;DR - what's this PR for?

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Urgency

  • How urgent is this? (Normal, High)

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to...
  4. Verify...

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@github-actions github-actions bot added the patch label Feb 15, 2024
@github-actions github-actions bot removed the patch label Feb 15, 2024
@pookmish pookmish force-pushed the D8CORE-7212 branch 2 times, most recently from d62d0c0 to 3851112 Compare February 16, 2024 04:03
@pookmish pookmish force-pushed the D8CORE-7212 branch 3 times, most recently from 64a7d3e to 702077a Compare February 27, 2024 23:08
@pookmish pookmish merged commit 0379316 into 11.x Feb 28, 2024
6 checks passed
@pookmish pookmish deleted the D8CORE-7212 branch February 28, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant