Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D8CORE-7096 | @jdwjdwjdw | Update algolia search results styles and structure #747

Merged
merged 3 commits into from
Nov 28, 2023
Merged

D8CORE-7096 | @jdwjdwjdw | Update algolia search results styles and structure #747

merged 3 commits into from
Nov 28, 2023

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Nov 22, 2023 •
edited
Loading

READY FOR REVIEW

Summary

  • D8CORE-7096: Style the search results in Stanford Basic

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add necessary Algolia API config at /admin/config/system/basic-site-settings
  3. Navigate to /search, and add a search
  4. View the search result page styles, and confirm they look good (the goal was to create an updated version of our current sites search styling)
  5. Review code ☃️

Associated Issues and/or People

  • D8CORE-7096: Style the search results in Stanford Basic

@jdwjdwjdw jdwjdwjdw requested a review from pookmish November 28, 2023 23:20
pookmish
pookmish approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@pookmish pookmish enabled auto-merge (squash) November 28, 2023 23:21
@pookmish pookmish merged commit 1fc74c6 into 11.x Nov 28, 2023
6 checks passed
@pookmish pookmish deleted the D8CORE-7096--style-search-results branch November 28, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pookmish pookmish pookmish approved these changes

Assignees

@pookmish pookmish

Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdwjdwjdw @pookmish