D8CORE-6976: updated to newest decanter

[jenbreese]

READY FOR REVIEW

Summary

• Updated to new Decanter to remove the italics on quotes.
• It also has all the webpack refactoring. I want to call this out in case you want to do more testing.

Review By (Date)

• When time

Criticality

• Normal

Urgency

• Normal

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Checkout this other branch: D8CORE-6976: updating the Decanter version stanford_profile_helper#278
3. Rebuild Cache and import config drush cr ; drush ci
4. Navigate to a page
5. Add a text paragraph with some text styled with the quote style
6. Verify the text is not italic

Site Configuration Sync

• Is there a config:export in this PR that changes the config sync directory? NO

Front End Validation

• Design is approved by @ user?
• HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
• Cross-browser testing: Has been performed? Or, QA request ticket created?
• Automated accessibility: Scans performed? Or, QA request ticket created?
• Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-6976
SU-SWS/stanford_profile_helper#278

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[pookmish]

FWIW, ^6.2.14 still captures 6.3.2... But should there be an updated yarn.lock file with this?

[jenbreese]

I added the yarn.lock file. But, why would ^6.2.14 pick up the newer version? I'm missing something fundamental here.

[pookmish]

It's because of the caret ^. It allows for versions up to a certain version. ^6.2 14 will download all versions up to 7.0.0. So it will download even 6.99.99 if a version existed

You can see this using this near semver calculator: https://semver.npmjs.com/