Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-1007: Added su-masthead-inner class to masthead <section> #725

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

joegl
Copy link
Contributor

@joegl joegl commented Oct 16, 2023

READY FOR REVIEW

Summary

  • Added the su-masthead-inner class to the <section> in the header.su-masthead. @jenbreese has requested a class on this <section> to make targeting it easer in sub-themes.
  • The name of the class doesn't have to be su-masthead--inner but whatever makes the most sense here.

Review By (Date)

ASAP

Urgency

  • Low/Med

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to home page
  4. Verify the <section> in the header.su-masthead has the su-masthead--inner class.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

Copy link
Contributor

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple Enough

@pookmish pookmish merged commit 79b6c16 into 11.x Oct 17, 2023
4 checks passed
@pookmish pookmish deleted the SDSS--1007--add-su-masthead-inner-class branch October 17, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants