Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-6951 | @jdwjdwjdw | D10 Clean up admin toolbar #723

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Oct 11, 2023

READY FOR REVIEW

Summary

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Confirm that the admin toolbar li's no longer have the additional margin-bottom being applied
    image
  3. Review code 🍰

Associated Issues and/or People

@@ -0,0 +1,8 @@
@charset 'UTF-8';

.toolbar-menu {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works, but put it in the admin scss file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, updated.

@jdwjdwjdw jdwjdwjdw requested a review from pookmish October 12, 2023 21:08
@pookmish pookmish merged commit ccd08c6 into 11.x Oct 12, 2023
4 checks passed
@pookmish pookmish deleted the D8CORE-6951--D10-admin-toolbar branch October 12, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants