Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-2761: padding on filter by menu #716

Closed
wants to merge 2 commits into from

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Sep 21, 2023

NOT READY FOR REVIEW

Summary

  • Added and removed padding on the filter by menus
  • The filter by menu is on news, publications, events, people

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • low

Urgency

  • low

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to an example of all the list pages
  4. Verify the down caret doesn't fold under the label.
  5. Try different responsive sizes.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory? NO

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-2761

Resources

@jenbreese jenbreese requested a review from jdwjdwjdw October 6, 2023 22:46
@jenbreese jenbreese removed the request for review from jdwjdwjdw October 9, 2023 23:15
@jenbreese jenbreese closed this Oct 11, 2023
@jenbreese jenbreese deleted the D8CORE-2761--filter-by-padding branch October 11, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants