Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-6896: changed the non discrimination link #707

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

jenbreese
Copy link
Contributor

READY FOR REVIEW

Summary

  • updated to the new Decanter.
  • Updates the non-discrimination link
  • added the rel=nofollow to all the footer links.

Review By (Date)

  • 9/14

Criticality

  • High on ticket

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr
  3. Navigate to a page
  4. Verify the footer links have changed to the new non-discrimation link https://non-discrimination.stanford.edu/
  5. It is a redirect so doesn't look different.
  6. verify the links all still work with the rel=nofollow.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory? NO

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-6896

Resources

@pookmish pookmish merged commit 553f3d9 into 10.x Sep 11, 2023
4 checks passed
@pookmish pookmish deleted the D8CORE-6896--non-discrimination branch September 11, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants