D8CORE-6843: Update bad user guide links in help text

[buttonwillowsix]

READY FOR REVIEW

Summary

• The help text on Stanford Sites sometime links to a "sites" URL for the User Guide. This was updated to use the vanity.
• Links to pages that no longer exist were removed

Review By (Date)

• None

Criticality

• Medium. Those links have generated a few help tickets and a feedback form

Urgency

• Normal

Review Tasks

Setup tasks and/or behavior to test

1. Go to a field that has help text that links to the guide (like Event Type on the Event Node)
2. Click on the link(s) in the help text
3. Go to the correct page on the 4.0 version of the User Guide

Site Configuration Sync

• Is there a config:export in this PR that changes the config sync directory?
• YES

Front End Validation

• Design is approved by @ user?
• HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
• Cross-browser testing: Has been performed? Or, QA request ticket created?
• Automated accessibility: Scans performed? Or, QA request ticket created?
• Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

-D8CORE-6843

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[pookmish]

Thanks