D8CORE-4551: updated permissions for contributors and site editors

[imonroe]

READY FOR REVIEW

Summary

• We are altering some permissions for contributors and site editors. We are adding the site-embedder role.

Review By (Date)

• code freeze.

Criticality

• 2

Urgency

• Normal

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Rebuild Cache and import config drush cr ; drush ci
3. Check to make sure the permissions are set correctly.

Site Configuration Sync

• Is there a config:export in this PR that changes the config sync directory? YES

Front End Validation

• Design is approved by @ user?
• HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
• Cross-browser testing: Has been performed? Or, QA request ticket created?
• Automated accessibility: Scans performed? Or, QA request ticket created?
• Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

• JIRA ticket(s)
• Other PRs
• Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
• Anyone who should be notified? (@mention them here)

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[imonroe]

@buttonwillowsix -- Would you please have a look at this and let me know if I have correctly captured all the changes? Between the ticket and my notes, it got a little confusing....

[pookmish]

Just looking for a little test

[pookmish]

can you add a couple codeception tests for this role

[imonroe]

can do.