Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7657: fixed person list and person cards #19

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

jenbreese
Copy link
Contributor

READY FOR REVIEW

Summary

  • Changed alignment to center
  • Increased image size

Review By (Date)

  • 11/22

Criticality

  • High

Urgency

  • High

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this Gitpod
  2. Create some people
  3. create a people list with a red background
  4. Verify the red people cards look good.
  5. Verify the /people page looks good.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-7657

Resources

Copy link
Contributor

@buttonwillowsix buttonwillowsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much improved teasers for people!

@buttonwillowsix buttonwillowsix merged commit 616b992 into 1.x Nov 22, 2024
1 check passed
@buttonwillowsix buttonwillowsix deleted the D8CORE-7657--people-cards branch November 22, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants