Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRSR24-34 | @jdwjdwjdw | Update red and grey event card heading styles #18

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Mar 25, 2024

READY FOR REVIEW

Summary

Review By (Date)

  • ASAP

Urgency

  • High

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add a basic page and test out the IRSR banner variants with all of the different heading options. Confirm that the h3, h4 and splash text headings are serif and have a consistent margin-bottom
  3. Add an example event
  4. Add a basic page and test out events card lists and events teasers with both the red and grey card colors. Confirm that the heading styles are correct when the heading is an h3
  5. Review code 🐿️

Associated Issues and/or People

  • IRSR24-34: Review IRSR theme for the 5.2 Release

Copy link
Contributor

@rebeccahongsf rebeccahongsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @jdwjdwjdw! LGTM 🚀

@jdwjdwjdw jdwjdwjdw merged commit d56db25 into 1.x Mar 28, 2024
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the IRSR23-34--v5.2-fixups branch March 28, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants