Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRSR24-31 | @jdwjdwjdw | Update search icon color, update version #16

Merged
merged 2 commits into from
Nov 21, 2023
Merged

IRSR24-31 | @jdwjdwjdw | Update search icon color, update version #16

merged 2 commits into from
Nov 21, 2023

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Nov 20, 2023 •
edited
Loading

READY FOR REVIEW

Summary

  • IRSR24-31: Change search icon to digital red
  • Add two-grid teaser variant fixup (spacing issue for third teaser, see image below)
    Screenshot 2023-11-20 at 4 10 06 PM

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Confirm that the menu search link icon color has been updated to su-color-digital-red
  3. Add a max-2-grid teaser paragraph to a basic page with at least 6 items, and confirm that there aren't any spacing issues in the gaps between the cards
  4. Review code 🍠

Associated Issues and/or People

  • IRSR24-31: Change search icon to digital red

rebeccahongsf
rebeccahongsf approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@rebeccahongsf rebeccahongsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃 Thanks @jdwjdwjdw !

@jdwjdwjdw jdwjdwjdw merged commit 293bfc0 into 1.x Nov 21, 2023
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the IRSR24-31--update-search-icon branch November 21, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebeccahongsf rebeccahongsf rebeccahongsf approved these changes

@buttonwillowsix buttonwillowsix Awaiting requested review from buttonwillowsix

Assignees

@buttonwillowsix buttonwillowsix

@rebeccahongsf rebeccahongsf

Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdwjdwjdw @rebeccahongsf @buttonwillowsix