Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-918: Storyblok Redirects. #357

Merged
merged 2 commits into from
Oct 15, 2024
Merged

DS-918: Storyblok Redirects. #357

merged 2 commits into from
Oct 15, 2024

Conversation

sherakama
Copy link
Member

@sherakama sherakama commented Oct 11, 2024

READY FOR REVIEW

Summary

  • Adds redirects to website

Review By (Date)

  • End of sprint

Criticality

  • Normal

Review Tasks

  1. Navigate to the following URLs
  2. https://deploy-preview-357--giving-campaign.netlify.app/this-is-just-a-test
  3. Validate you are redirected to /changemakers
  4. Create and modify the redirects in Storyblok
  5. Create a new redirect
  6. Try putting in some garbage into the fields to see if the regex catches it

Associated Issues and/or People

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for giving-campaign ready!

Name Link
🔨 Latest commit b7a31d0
🔍 Latest deploy log https://app.netlify.com/sites/giving-campaign/deploys/670eb9fef066670008464081
😎 Deploy Preview https://deploy-preview-357--giving-campaign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@ericbakenhus ericbakenhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🪨

Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Tour, works here 🎉

@sherakama sherakama merged commit 2c2ce2b into dev Oct 15, 2024
1 check passed
@sherakama sherakama deleted the DS-918/redirects branch October 15, 2024 18:52
@sherakama sherakama mentioned this pull request Oct 16, 2024
sherakama added a commit that referenced this pull request Oct 16, 2024
* DS-918: Storyblok Redirects. (DS-918: Storyblok Redirects. #357)
* NoJira: Force token through sbParams. (NoJira: Force token through sbParams. #360)
yvonnetangsu added a commit that referenced this pull request Oct 31, 2024
* dev: (22 commits)
  3.2.1
  DS-1016 | Sync tour changes and clean up; update packages (#365)
  DS-850 | Annotated image tweak (#363)
  Nojira | More robust URL processing; prevent empty redirect entries causing build error (#362)
  3.2.0
  NoJira: Force token through sbParams. (#360)
  DS-918: Storyblok Redirects. (#357)
  3.1.0
  Better key for hotspot li; honor priority loading option; lazy load ankle banner image (#358)
  DS-850 | Annotated image component (#343)
  3.0.2
  HOTFIX: API Throttling. (#355)
  3.0.1
  NoJira: Use preview key in background function.
  3.0.0
  Remove signature check due to Storyblok silliness. (#353)
  DS-917: Deploy webhook (#351)
  DS-916: Split paths and Slug Prefix. (#350)
  2.5.8
  DS-911 | Update dependencies (#348)
  ...

# Conflicts:
#	app/(storyblok)/[[...slug]]/not-found.tsx
#	app/not-found.tsx
#	tailwind/plugins/theme/gc-keyframes.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants