GIVCAMP-202 | Vertical featured story poster with cutout text exploration #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: GIVCAMP-220 | Grid options and story card section layouts (#128)
…Vertical Poster styles
✅ Deploy Preview for giving-campaign ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yvonnetangsu
changed the title
yvonnetangsu
commented
Oct 5, 2023
|
|
||
| type SbHomepageMvpProps = { | ||
| blok: { | ||
| _uid: string; | ||
| title?: string; | ||
| intro: string; | ||
| featuredStories?: SbBlokData[]; |
There was a problem hiding this comment.
Remove the "featuredStories" region in Homepage MVP page type in Storyblok, because they're mixing the featured stories with other content now. So basically everything gets absorbed into the content region
|
This is demo'ed to the client and approved so I'm merging this in. As usual, anything is open to updates and we'll keep iterating. |
|
|
yvonnetangsu
commented
Oct 5, 2023
| 'mb-0 fluid-type-8 bg-fixed bg-cover bg-center bg-no-repeat hyphens-auto', { | ||
| 'lg:fluid-type-6 2xl:fluid-type-7 4xl:fluid-type-8': isSmallHeading, | ||
| 'md:fluid-type-9': !isSmallHeading, | ||
| 'bg-clip-text text-black/40': hasBgImage, |
There was a problem hiding this comment.
This is how I created the cutout text effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review By (Date)
Review Tasks
Setup tasks and/or behavior to test
Associated Issues and/or People