Nojira | Update nextjs to v13.4.20-canary.12; enable static export; remove use of next image #112

yvonnetangsu · 2023-08-19T00:06:04Z

READY FOR REVIEW

Summary

Enable static export
Note: Previously, after updating to anything about next v13.4.9, I couldn't manually go to a page by typing in the URL (using internal links on the site works just fine). This seems to have fixed that problem. Also, previously, going to a non-existent page would show the "error" component, now, it shows the "not-found" component which is preferable.
Note: TBH I think the app directory still isn't 100% ready for production, but it's good to test things out 🤔

Review By (Date)

Whenever

Review Tasks

Setup tasks and/or behavior to test

Go to the preview and see that all the interaction still works, and it looks the same as before
https://deploy-preview-112--giving-campaign.netlify.app/
Manually type initiatives after the above URL and hit enter, and check that you're taking to the initiative page instead of an error page
Go to https://deploy-preview-112--giving-campaign.netlify.app/monkey and see that it shows the "Not found" temp page.
See comments in the code

…tjs to latest

netlify · 2023-08-19T00:06:10Z

✅ Deploy Preview for giving-campaign ready!

Name	Link
🔨 Latest commit	`a5a7fcf`
🔍 Latest deploy log	https://app.netlify.com/sites/giving-campaign/deploys/6515521c3f1fab0008789053
😎 Deploy Preview	https://deploy-preview-112--giving-campaign.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

* dev: Add resolve relations to bridgeOptions for StoryblokStory (#113)

yvonnetangsu · 2023-08-30T20:40:40Z

app/[...slug]/page.tsx

@@ -14,7 +14,7 @@ type ParamsType = {
  slug: string[];
 };

-async function generateStaticParams() {
+export async function generateStaticParams() {


To use static export, I need to add export back here. Previously it generates a type error, but it seems ok now.

yvonnetangsu · 2023-08-30T20:41:00Z

next.config.js

 const nextConfig = {
+  trailingSlash: true,
+  output: 'export',


To enable static export

yvonnetangsu · 2023-08-30T20:41:18Z

netlify.toml

+  publish = "out"
+
+[build.environment]
+  # For apps that use next export to generate static HTML
+  # set the NETLIFY_NEXT_PLUGIN_SKIP to true.
+  NETLIFY_NEXT_PLUGIN_SKIP="true"


These need to be set to use static export

What? Really? Link to Doxn?

Here you go @sherakama
https://nextjs.org/docs/app/building-your-application/deploying/static-exports

It would also show me an error on the Netlify build page to do these two things

TBH I'm not 100% sure I want to go with this - but at least I finally get it to work once 😂 All the combination of things that blocked this from working before.....

yvonnetangsu · 2023-08-30T22:41:43Z

@sherakama Another thing of interest - comparing deploy time before and after switching to static export + the nextjs update 🤔 ~1.5 min (before) vs ~30s (after)

* dev: GIVCAMP-199 | New homepage hero (#122) # Conflicts: # components/Homepage/HomepageSplitHero.tsx

…blokData in some SB components

…ra_update-package * feature/GIVCAMP-201_blurry-bg-poster: eslint update and lint fix Image on left option linter and clean up more styles BlurryPoster and new MVP Homepage components; better typing for StoryblokData in some SB components Create Blurry Poster component GIVCAMP-199 | New homepage hero (#122) More finetuning responsive Clean up Play with hero animation make font size fluid; positioning of hero elements sr only H1 New homepage hero GIVCAMP-198 | homepage Ideal fellow section with parallax explore (#121) GIVCAMP-197 | Changemaker card and section (#120) GIVCAMP-194 | Low budget data viz poc (#119) GIVCAMP-188 | Horizontal brochure poc; new CTA style (#118) Modularize import for heroicons (#117) # Conflicts: # components/Storyblok/SbHomepage.tsx # package-lock.json # package.json

…ra_update-package * feature/GIVCAMP-201_blurry-bg-poster: Revert old homepage; uninstall netlify nextjs plugin # Conflicts: # components/Storyblok/SbHomepage.tsx # package-lock.json # package.json

yvonnetangsu · 2023-09-28T10:21:05Z

@sherakama I merged the latest changes (some not yet in dev) into this branch because I created a new home page using the new SbHomepageMvp component. Merging this change in prevents any future builds in this PR from breaking and allows you to view the new homepage on your local 😄

Also, I uninstalled the netlify nextjs plugin as you suggested. The build log shows that it now automatically install the latest version - thanks!

yvonnetangsu · 2023-10-18T21:11:08Z

I think I can close this one for now

yvonnetangsu · 2023-12-15T01:50:34Z

@sherakama I previously had this PR which enables static export, and upgraded to 13.4.20-canary.12 which seems to be fine. No Safari button issue and 404 page seems ok too. Tagging you to see if there's anything we can use here.

Update nextjs to v13.4.18, eslint-config-next and @netlify/plugin-nex…

5e7d8c6

…tjs to latest

yvonnetangsu and others added 10 commits August 18, 2023 17:14

Add try/catch to generateMetaData

5242c88

Merge branch 'dev' into feature/nojira_update-package

a0cdb09

* dev: Add resolve relations to bridgeOptions for StoryblokStory (#113)

Just trying next canary

f87724a

See if this fixes the problem where I can't directly type in the URL

12483f7

Merge branch 'dev' into feature/nojira_update-package

5c0bd6e

Remove throw error for generate metadata

463b494

Trying output: export again

a2b23ae

add export back to generateStaticParams

c5aaf7a

Change build directory and have NETLIFY_NEXT_PLUGIN_SKIP="true" for SSG

44cd07b

Remove the use of next Image

2f50c09

yvonnetangsu changed the title ~~Nojira | Update nextjs to v13.4.18 and other packages~~ Nojira | Update nextjs to v13.4.20-canary.12; enable static export Aug 30, 2023

yvonnetangsu changed the title ~~Nojira | Update nextjs to v13.4.20-canary.12; enable static export~~ Nojira | Update nextjs to v13.4.20-canary.12; enable static export; remove use of next image Aug 30, 2023

yvonnetangsu marked this pull request as ready for review August 30, 2023 19:56

yvonnetangsu requested a review from sherakama August 30, 2023 20:40

yvonnetangsu commented Aug 30, 2023

View reviewed changes

yvonnetangsu added 10 commits September 25, 2023 03:15

New homepage hero

15c35aa

sr only H1

e8413a8

make font size fluid; positioning of hero elements

42d3b51

Play with hero animation

389404e

Clean up

be0f92e

More finetuning responsive

e795c9f

Create Blurry Poster component

7ab1cde

Merge branch 'dev' into feature/GIVCAMP-201_blurry-bg-poster

9218696

* dev: GIVCAMP-199 | New homepage hero (#122) # Conflicts: # components/Homepage/HomepageSplitHero.tsx

BlurryPoster and new MVP Homepage components; better typing for Story…

72ce669

…blokData in some SB components

more styles

79ab80f

yvonnetangsu added 7 commits September 26, 2023 16:48

linter and clean up

9a5eefe

Image on left option

f09565d

eslint update and lint fix

6fc8d67

Revert old homepage; uninstall netlify nextjs plugin

380e048

Merge branch 'feature/GIVCAMP-201_blurry-bg-poster' into feature/noji…

30bb0a5

…ra_update-package * feature/GIVCAMP-201_blurry-bg-poster: Revert old homepage; uninstall netlify nextjs plugin # Conflicts: # components/Storyblok/SbHomepage.tsx # package-lock.json # package.json

Uninstall netlify plugin nextjs

a5a7fcf

yvonnetangsu mentioned this pull request Oct 18, 2023

GIVCAMP-178: Package and node version updates. #127

Merged

yvonnetangsu closed this Oct 18, 2023

sherakama deleted the feature/nojira_update-package branch December 18, 2023 17:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nojira | Update nextjs to v13.4.20-canary.12; enable static export; remove use of next image #112

Nojira | Update nextjs to v13.4.20-canary.12; enable static export; remove use of next image #112

yvonnetangsu commented Aug 19, 2023 •

edited

Loading

netlify bot commented Aug 19, 2023 •

edited

Loading

yvonnetangsu Aug 30, 2023

yvonnetangsu Aug 30, 2023

yvonnetangsu Aug 30, 2023

sherakama Aug 30, 2023

yvonnetangsu Aug 30, 2023 •

edited

Loading

yvonnetangsu Aug 30, 2023

yvonnetangsu commented Aug 30, 2023 •

edited

Loading

yvonnetangsu commented Sep 28, 2023

yvonnetangsu commented Oct 18, 2023

yvonnetangsu commented Dec 15, 2023

Nojira | Update nextjs to v13.4.20-canary.12; enable static export; remove use of next image #112

Nojira | Update nextjs to v13.4.20-canary.12; enable static export; remove use of next image #112

Conversation

yvonnetangsu commented Aug 19, 2023 • edited Loading

READY FOR REVIEW

Summary

Review By (Date)

Review Tasks

Setup tasks and/or behavior to test

netlify bot commented Aug 19, 2023 • edited Loading

✅ Deploy Preview for giving-campaign ready!

yvonnetangsu Aug 30, 2023

Choose a reason for hiding this comment

yvonnetangsu Aug 30, 2023

Choose a reason for hiding this comment

yvonnetangsu Aug 30, 2023

Choose a reason for hiding this comment

sherakama Aug 30, 2023

Choose a reason for hiding this comment

yvonnetangsu Aug 30, 2023 • edited Loading

Choose a reason for hiding this comment

yvonnetangsu Aug 30, 2023

Choose a reason for hiding this comment

yvonnetangsu commented Aug 30, 2023 • edited Loading

yvonnetangsu commented Sep 28, 2023

yvonnetangsu commented Oct 18, 2023

yvonnetangsu commented Dec 15, 2023

yvonnetangsu commented Aug 19, 2023 •

edited

Loading

netlify bot commented Aug 19, 2023 •

edited

Loading

yvonnetangsu Aug 30, 2023 •

edited

Loading

yvonnetangsu commented Aug 30, 2023 •

edited

Loading