Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ostanki issue14 #16

Merged
merged 38 commits into from
Jan 11, 2020
Merged

Ostanki issue14 #16

merged 38 commits into from
Jan 11, 2020

Conversation

ostanki
Copy link
Contributor

@ostanki ostanki commented Dec 4, 2019

Issue 14 add STM32F407ZET6 STM32_F4XX board

@ostanki ostanki marked this pull request as ready for review December 8, 2019 15:11
@ostanki
Copy link
Contributor Author

ostanki commented Dec 8, 2019

In this fork/branch the only (relevant) changes are:
New board in boards/STM32F407ZET6-STM32_F4XX.md

  • new schematic in assets/pdf/boards/original-schematic-STM32F407ZET6-STM32_F4XX.pdf
  • new images: assets/img/boards/STM32F407ZET6-STM32_F4xx_1.jpg
    assets/img/boards/STM32F407ZET6-STM32_F4xx_2.jpg
    assets/img/boards/STM32F407ZET6-STM32_F4xx_3.jpg

@ThomasGravekamp
Copy link
Contributor

This branch is now conflicting with the master branch. You can probably resolve this by rebasing your branch onto the master branch and only keeping the commits related to this new board.

boards/STM32F407ZET6-STM32_F4XX.md Outdated Show resolved Hide resolved
boards/STM32F407ZET6-STM32_F4XX.md Outdated Show resolved Hide resolved
boards/STM32F407ZET6-STM32_F4XX.md Outdated Show resolved Hide resolved
boards/STM32F407ZET6-STM32_F4XX.md Outdated Show resolved Hide resolved
boards/STM32F407ZET6-STM32_F4XX.md Outdated Show resolved Hide resolved
boards/STM32F407ZET6-STM32_F4XX.md Outdated Show resolved Hide resolved
@ThomasGravekamp
Copy link
Contributor

Thanks for your contribution!

If you're interested in the data structure I'm designing to make things like these easier, take a look at the refactor-board-pages branch. And then especially the json files in the _data/boards folder.

Copy link
Contributor

@ThomasGravekamp ThomasGravekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing left to do is rename the files related to this board. The file names of the images are currently not consistent with the file name of the board page. And I personally think that the file name doesn't need the underscore in there, since the name STM32F4XX is written quite big on the board, on both sides.

Removed typo. SD card pin 9 now:  | Card Detect  | Ground Plane |
@ThomasGravekamp ThomasGravekamp merged commit d9a4a9a into STM32-base:master Jan 11, 2020
@ostanki ostanki deleted the ostanki-issue14 branch February 19, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants