Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent HPX master has changed some namespaces for the executor traits specialization #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Recent HPX master has changed some namespaces for the executor traits specialization #25

wants to merge 2 commits into from

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Nov 27, 2024

No description provided.

msimberg
msimberg requested changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @hkaiser! Not sure about the version check, otherwise this looks good.

I suppose this warrants a new patch release. I can take care of that separately if you'd like.

src/hpx/kokkos/config.hpp Show resolved Hide resolved
@msimberg
Copy link
Collaborator

@hkaiser do you want someone (@G-071) to test this as well before merging, or ok to merge as-is (at least the github actions workflow passed)? You have rights to merge as well of course, feel free to do so.

@hkaiser
Copy link
Member Author

hkaiser commented Nov 27, 2024

@hkaiser do you want someone (@G-071) to test this as well before merging, or ok to merge as-is (at least the github actions workflow passed)? You have rights to merge as well of course, feel free to do so.

Let's have @diehlpk test it as he ran across the issue before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hkaiser @msimberg