-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only enable TPIE's logging while in Debug #692
Conversation
d222662
to
c30b0a3
Compare
The TPIE_log*.txt file can within a single day get very large, e.g. 3.5+ TiB large. Yet, it is very seldomly (if ever) we need it - especially not in production.
c30b0a3
to
ec0f896
Compare
🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')'ssoelvsten/adiar/tpie/disable_log' is a change in performance of 0.18% (stdev: 1.11%).
Number of samples: 10 |
🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')'ssoelvsten/adiar/tpie/disable_log' is a change in performance of 1.17% (stdev: 1.42%).
Number of samples: 10 |
🔴 Regression Test (Picotrav 'adder')'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -1.13% (stdev: 0.52%).
Number of samples: 10 |
🟡 Regression Test (12-Queens)'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.31% (stdev: 0.87%).
Number of samples: 10 |
🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')'ssoelvsten/adiar/tpie/disable_log' is a change in performance of 1.22% (stdev: 1.04%).
Number of samples: 10 |
🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.00% (stdev: 0.75%).
Number of samples: 10 |
🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.32% (stdev: 0.65%).
Number of samples: 10 |
🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.09% (stdev: 0.60%).
Number of samples: 10 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
=========================================
Coverage 98.040% 98.040%
=========================================
Files 93 93
Lines 7093 7093
=========================================
Hits 6954 6954
Misses 139 139 ☔ View full report in Codecov by Sentry. |
🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.81% (stdev: 2.46%).
Number of samples: 10 |
🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')'ssoelvsten/adiar/tpie/disable_log' is a change in performance of 0.19% (stdev: 1.23%).
Number of samples: 10 |
🟡 Regression Test (Picotrav 'mem_ctrl')'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.09% (stdev: 0.25%).
Number of samples: 5 |
🟡 Regression Test (Picotrav 'arbiter')'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -4.62% (stdev: 14.45%).
Number of samples: 10 |
🟡 Regression Test (14-Queens)'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.08% (stdev: 0.41%).
Number of samples: 3 |
The TPIE_log*.txt file can within a single day get very large, e.g. 3.5+ TiB large. Yet, it is very seldomly (if ever) we need it - especially not in production.