Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable TPIE's logging while in Debug #692

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Aug 15, 2024

The TPIE_log*.txt file can within a single day get very large, e.g. 3.5+ TiB large. Yet, it is very seldomly (if ever) we need it - especially not in production.

@SSoelvsten SSoelvsten added ✨ feature New operation or other feature 📁 internal This is where the ✨magic✨happens labels Aug 15, 2024
@SSoelvsten SSoelvsten self-assigned this Aug 15, 2024
@SSoelvsten SSoelvsten force-pushed the tpie/disable_log branch 2 times, most recently from d222662 to c30b0a3 Compare August 15, 2024 08:32
The TPIE_log*.txt file can within a single day get very large, e.g. 3.5+ TiB large.
Yet, it is very seldomly (if ever) we need it - especially not in production.
Copy link

🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/tpie/disable_log' is a change in performance of 0.18% (stdev: 1.11%).

... origin/main ssoelvsten/adiar/tpie/disable_log
Mean 5220.60 5211.30
Standard Deviation 43.95 57.70

Number of samples: 10

Copy link

🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/tpie/disable_log' is a change in performance of 1.17% (stdev: 1.42%).

... origin/main ssoelvsten/adiar/tpie/disable_log
Mean 5126.00 5066.20
Standard Deviation 72.65 48.19

Number of samples: 10

Copy link

🔴 Regression Test (Picotrav 'adder')

'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -1.13% (stdev: 0.52%).

... origin/main ssoelvsten/adiar/tpie/disable_log
Mean 9393.90 9500.10
Standard Deviation 48.99 45.27

Number of samples: 10

Copy link

🟡 Regression Test (12-Queens)

'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.31% (stdev: 0.87%).

... origin/main ssoelvsten/adiar/tpie/disable_log
Mean 11594.60 11630.50
Standard Deviation 51.43 101.70

Number of samples: 10

Copy link

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/tpie/disable_log' is a change in performance of 1.22% (stdev: 1.04%).

... origin/main ssoelvsten/adiar/tpie/disable_log
Mean 12409.60 12258.60
Standard Deviation 129.10 88.67

Number of samples: 10

Copy link

🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.00% (stdev: 0.75%).

... origin/main ssoelvsten/adiar/tpie/disable_log
Mean 15393.80 15394.20
Standard Deviation 92.06 115.50

Number of samples: 10

Copy link

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.32% (stdev: 0.65%).

... origin/main ssoelvsten/adiar/tpie/disable_log
Mean 21906.30 21977.30
Standard Deviation 70.11 142.99

Number of samples: 10

Copy link

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.09% (stdev: 0.60%).

... origin/main ssoelvsten/adiar/tpie/disable_log
Mean 29736.10 29763.50
Standard Deviation 177.44 141.23

Number of samples: 10

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.040%. Comparing base (ddc613f) to head (ec0f896).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #692   +/-   ##
=========================================
  Coverage   98.040%   98.040%           
=========================================
  Files           93        93           
  Lines         7093      7093           
=========================================
  Hits          6954      6954           
  Misses         139       139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.81% (stdev: 2.46%).

... origin/main ssoelvsten/adiar/tpie/disable_log
Mean 9363.80 9439.80
Standard Deviation 106.80 232.13

Number of samples: 10

Copy link

🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'ssoelvsten/adiar/tpie/disable_log' is a change in performance of 0.19% (stdev: 1.23%).

... origin/main ssoelvsten/adiar/tpie/disable_log
Mean 17105.10 17073.10
Standard Deviation 210.65 69.02

Number of samples: 10

Copy link

🟡 Regression Test (Picotrav 'mem_ctrl')

'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.09% (stdev: 0.25%).

... origin/main ssoelvsten/adiar/tpie/disable_log
Mean 113550.80 113647.80
Standard Deviation 285.38 224.04

Number of samples: 5

Copy link

🟡 Regression Test (Picotrav 'arbiter')

'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -4.62% (stdev: 14.45%).

... origin/main ssoelvsten/adiar/tpie/disable_log
Mean 65128.90 68137.30
Standard Deviation 423.64 9844.40

Number of samples: 10

Copy link

🟡 Regression Test (14-Queens)

'ssoelvsten/adiar/tpie/disable_log' is a change in performance of -0.08% (stdev: 0.41%).

... origin/main ssoelvsten/adiar/tpie/disable_log
Mean 266100.33 266314.00
Standard Deviation 1081.40 832.75

Number of samples: 3

@SSoelvsten SSoelvsten merged commit db61cb3 into main Aug 15, 2024
54 of 57 checks passed
@SSoelvsten SSoelvsten deleted the tpie/disable_log branch August 30, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New operation or other feature 📁 internal This is where the ✨magic✨happens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant