Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/internal/sorter/memory usage #685

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Jul 1, 2024

Closes #683 .

@SSoelvsten SSoelvsten added the 🔥 bug Something isn't working label Jul 1, 2024
@SSoelvsten SSoelvsten self-assigned this Jul 1, 2024
@SSoelvsten SSoelvsten marked this pull request as ready for review July 1, 2024 12:13
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.033%. Comparing base (b99050d) to head (291d683).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #685   +/-   ##
=========================================
  Coverage   98.033%   98.033%           
=========================================
  Files           93        93           
  Lines         7067      7067           
=========================================
  Hits          6928      6928           
  Misses         139       139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Repository owner deleted a comment from github-actions bot Jul 1, 2024
@SSoelvsten SSoelvsten merged commit 4644ef0 into main Jul 1, 2024
15 checks passed
@SSoelvsten SSoelvsten deleted the bug/internal/sorter/memory_usage branch July 1, 2024 13:05
Copy link

github-actions bot commented Jul 1, 2024

🟡 Regression Test (Picotrav 'adder')

'ssoelvsten/adiar/bug/internal/sorter/memory_usage' is a change in performance of -3.38% (stdev: 8.89%).

... origin/main ssoelvsten/adiar/bug/internal/sorter/memory_usage
Mean 9237.20 9549.50
Standard Deviation 90.70 848.98

Number of samples: 10

Copy link

github-actions bot commented Jul 1, 2024

🟡 Regression Test (12-Queens)

'ssoelvsten/adiar/bug/internal/sorter/memory_usage' is a change in performance of 0.05% (stdev: 0.42%).

... origin/main ssoelvsten/adiar/bug/internal/sorter/memory_usage
Mean 11518.60 11512.50
Standard Deviation 47.56 48.13

Number of samples: 10

Copy link

github-actions bot commented Jul 1, 2024

🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/bug/internal/sorter/memory_usage' is a change in performance of -0.09% (stdev: 1.07%).

... origin/main ssoelvsten/adiar/bug/internal/sorter/memory_usage
Mean 5192.70 5197.60
Standard Deviation 21.97 55.64

Number of samples: 10

Copy link

github-actions bot commented Jul 1, 2024

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/bug/internal/sorter/memory_usage' is a change in performance of 0.17% (stdev: 0.52%).

... origin/main ssoelvsten/adiar/bug/internal/sorter/memory_usage
Mean 12146.30 12125.10
Standard Deviation 50.39 62.52

Number of samples: 10

Copy link

github-actions bot commented Jul 1, 2024

🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/bug/internal/sorter/memory_usage' is a change in performance of -0.00% (stdev: 0.47%).

... origin/main ssoelvsten/adiar/bug/internal/sorter/memory_usage
Mean 15416.70 15417.00
Standard Deviation 73.12 69.60

Number of samples: 10

Copy link

github-actions bot commented Jul 1, 2024

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/bug/internal/sorter/memory_usage' is a change in performance of -0.07% (stdev: 0.32%).

... origin/main ssoelvsten/adiar/bug/internal/sorter/memory_usage
Mean 22076.80 22091.50
Standard Deviation 70.34 46.83

Number of samples: 10

Copy link

github-actions bot commented Jul 1, 2024

🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/bug/internal/sorter/memory_usage' is a change in performance of -0.10% (stdev: 1.18%).

... origin/main ssoelvsten/adiar/bug/internal/sorter/memory_usage
Mean 5135.10 5140.20
Standard Deviation 55.13 60.72

Number of samples: 10

Copy link

github-actions bot commented Jul 1, 2024

🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/bug/internal/sorter/memory_usage' is a change in performance of -0.64% (stdev: 2.10%).

... origin/main ssoelvsten/adiar/bug/internal/sorter/memory_usage
Mean 9438.00 9498.00
Standard Deviation 170.19 199.22

Number of samples: 10

Copy link

github-actions bot commented Jul 1, 2024

🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'ssoelvsten/adiar/bug/internal/sorter/memory_usage' is a change in performance of -0.97% (stdev: 1.29%).

... origin/main ssoelvsten/adiar/bug/internal/sorter/memory_usage
Mean 16905.30 17069.20
Standard Deviation 57.54 220.19

Number of samples: 10

Copy link

github-actions bot commented Jul 1, 2024

🟡 Regression Test (Picotrav 'mem_ctrl')

'ssoelvsten/adiar/bug/internal/sorter/memory_usage' is a change in performance of -0.03% (stdev: 0.46%).

... origin/main ssoelvsten/adiar/bug/internal/sorter/memory_usage
Mean 114511.40 114551.40
Standard Deviation 316.81 522.85

Number of samples: 5

Copy link

github-actions bot commented Jul 1, 2024

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/bug/internal/sorter/memory_usage' is a change in performance of 0.16% (stdev: 0.94%).

... origin/main ssoelvsten/adiar/bug/internal/sorter/memory_usage
Mean 29625.30 29576.50
Standard Deviation 279.79 239.02

Number of samples: 10

Copy link

github-actions bot commented Jul 1, 2024

🟡 Regression Test (Picotrav 'arbiter')

'ssoelvsten/adiar/bug/internal/sorter/memory_usage' is a change in performance of -4.85% (stdev: 14.81%).

... origin/main ssoelvsten/adiar/bug/internal/sorter/memory_usage
Mean 65172.50 68331.00
Standard Deviation 131.19 10119.08

Number of samples: 10

Copy link

github-actions bot commented Jul 1, 2024

🟡 Regression Test (14-Queens)

'ssoelvsten/adiar/bug/internal/sorter/memory_usage' is a change in performance of 0.07% (stdev: 0.46%).

... origin/main ssoelvsten/adiar/bug/internal/sorter/memory_usage
Mean 267533.33 267345.33
Standard Deviation 965.89 1222.14

Number of samples: 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorter memory incorrect!
1 participant