Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDD/RelProd/Apply Transpose #672

Merged
merged 4 commits into from
Jun 13, 2024
Merged

BDD/RelProd/Apply Transpose #672

merged 4 commits into from
Jun 13, 2024

Conversation

SSoelvsten
Copy link
Owner

Optimisation from #502 : Skips the transposition step of the bdd_exists by using the unreduced (and already transposed) output of bdd_and.

@SSoelvsten SSoelvsten added ✨ optimisation It's all about speed / space 📁 bdd Binary Decision Diagrams labels Jun 13, 2024
@SSoelvsten SSoelvsten added this to the v2.1 : Relational Product milestone Jun 13, 2024
@SSoelvsten SSoelvsten self-assigned this Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 96.61017% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.846%. Comparing base (183a4f3) to head (9f3bb15).
Report is 1 commits behind head on main.

Files Patch % Lines
src/adiar/bdd/quantify.cpp 87.500% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main      #672       +/-   ##
=============================================
+ Coverage   97.829%   97.846%   +0.017%     
=============================================
  Files           93        93               
  Lines         6863      6917       +54     
=============================================
+ Hits          6714      6768       +54     
  Misses         149       149               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 13, 2024

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/bdd/relprod/apply_transpose' is a change in performance of 0.15% (stdev: 0.29%).

... origin/main ssoelvsten/adiar/bdd/relprod/apply_transpose
Mean 21846.67 21814.00
Standard Deviation 62.53 47.32

Number of samples: 3

Copy link

github-actions bot commented Jun 13, 2024

🟢 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'ssoelvsten/adiar/bdd/relprod/apply_transpose' is a change in performance of 1.63% (stdev: 0.58%).

... origin/main ssoelvsten/adiar/bdd/relprod/apply_transpose
Mean 17163.00 16884.00
Standard Deviation 31.80 97.86

Number of samples: 3

Copy link

github-actions bot commented Jun 13, 2024

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/bdd/relprod/apply_transpose' is a change in performance of -0.35% (stdev: 0.42%).

... origin/main ssoelvsten/adiar/bdd/relprod/apply_transpose
Mean 29231.33 29334.67
Standard Deviation 123.14 29.26

Number of samples: 3

Copy link

github-actions bot commented Jun 13, 2024

🟡 Regression Test (Picotrav 'adder')

'ssoelvsten/adiar/bdd/relprod/apply_transpose' is a change in performance of -1.35% (stdev: 1.19%).

... origin/main ssoelvsten/adiar/bdd/relprod/apply_transpose
Mean 9475.25 9603.50
Standard Deviation 112.01 114.44

Number of samples: 4

Copy link

github-actions bot commented Jun 13, 2024

🟢 Regression Test (Picotrav 'arbiter')

'ssoelvsten/adiar/bdd/relprod/apply_transpose' is a change in performance of 0.34% (stdev: 1.54%).

... origin/main ssoelvsten/adiar/bdd/relprod/apply_transpose
Mean 65868.00 65644.00
Standard Deviation 1016.28 907.01

Number of samples: 3

Copy link

github-actions bot commented Jun 13, 2024

🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/bdd/relprod/apply_transpose' is a change in performance of -1.21% (stdev: 1.83%).

... origin/main ssoelvsten/adiar/bdd/relprod/apply_transpose
Mean 4988.00 5048.50
Standard Deviation 59.35 92.31

Number of samples: 4

Copy link

github-actions bot commented Jun 13, 2024

🟢 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/bdd/relprod/apply_transpose' is a change in performance of 1.95% (stdev: 2.45%).

... origin/main ssoelvsten/adiar/bdd/relprod/apply_transpose
Mean 9516.25 9330.25
Standard Deviation 232.69 56.51

Number of samples: 4

Copy link

github-actions bot commented Jun 13, 2024

🟢 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/bdd/relprod/apply_transpose' is a change in performance of 0.33% (stdev: 0.56%).

... origin/main ssoelvsten/adiar/bdd/relprod/apply_transpose
Mean 12298.00 12258.00
Standard Deviation 4.58 68.74

Number of samples: 3

Copy link

github-actions bot commented Jun 13, 2024

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/bdd/relprod/apply_transpose' is a change in performance of 0.22% (stdev: 0.72%).

... origin/main ssoelvsten/adiar/bdd/relprod/apply_transpose
Mean 15313.33 15279.33
Standard Deviation 110.53 70.54

Number of samples: 3

Copy link

github-actions bot commented Jun 13, 2024

🟢 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/bdd/relprod/apply_transpose' is a change in performance of 0.32% (stdev: 1.23%).

... origin/main ssoelvsten/adiar/bdd/relprod/apply_transpose
Mean 5178.75 5162.25
Standard Deviation 63.95 55.23

Number of samples: 4

Copy link

github-actions bot commented Jun 13, 2024

🔴 Regression Test (Picotrav 'mem_ctrl')

'ssoelvsten/adiar/bdd/relprod/apply_transpose' is a change in performance of -0.60% (stdev: 0.24%).

... origin/main ssoelvsten/adiar/bdd/relprod/apply_transpose
Mean 114685.33 115377.67
Standard Deviation 270.93 148.19

Number of samples: 3

Copy link

github-actions bot commented Jun 13, 2024

🟢 Regression Test (12-Queens)

'ssoelvsten/adiar/bdd/relprod/apply_transpose' is a change in performance of 0.14% (stdev: 0.49%).

... origin/main ssoelvsten/adiar/bdd/relprod/apply_transpose
Mean 11628.75 11612.00
Standard Deviation 56.68 55.75

Number of samples: 4

@SSoelvsten SSoelvsten force-pushed the bdd/relprod/apply_transpose branch from 93a9716 to 9f3bb15 Compare June 13, 2024 12:52
Copy link

🟡 Regression Test (14-Queens)

'ssoelvsten/adiar/bdd/relprod/apply_transpose' is a change in performance of -0.41% (stdev: 0.91%).

... origin/main ssoelvsten/adiar/bdd/relprod/apply_transpose
Mean 270533.00 271653.33
Standard Deviation 1187.18 2471.16

Number of samples: 3

@SSoelvsten SSoelvsten merged commit 1923c68 into main Jun 13, 2024
55 of 60 checks passed
@SSoelvsten SSoelvsten deleted the bdd/relprod/apply_transpose branch June 13, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 bdd Binary Decision Diagrams ✨ optimisation It's all about speed / space
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant