Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'quantify pred-profile' to have more information for heuristics #661

Merged
merged 6 commits into from
May 7, 2024

Conversation

SSoelvsten
Copy link
Owner

Deals with pre-requisites for #655 .

@SSoelvsten SSoelvsten added ✨ optimisation It's all about speed / space ✨ code quality Uncle Bob would be proud labels Apr 30, 2024
@SSoelvsten SSoelvsten self-assigned this Apr 30, 2024
@SSoelvsten SSoelvsten force-pushed the internal/quantify/pred-profile branch from f94fde8 to 7b3579c Compare April 30, 2024 14:44
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.375%. Comparing base (f409f0f) to head (6f272c3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #661       +/-   ##
=============================================
+ Coverage   97.371%   97.375%   +0.004%     
=============================================
  Files           90        90               
  Lines         6505      6515       +10     
=============================================
+ Hits          6334      6344       +10     
  Misses         171       171               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 30, 2024

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/internal/quantify/pred-profile' is a change in performance of -0.44% (stdev: 0.45%).

... origin/main ssoelvsten/adiar/internal/quantify/pred-profile
Mean 29553.33 29682.00
Standard Deviation 124.27 132.84

Number of samples: 3

Copy link

github-actions bot commented Apr 30, 2024

🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/internal/quantify/pred-profile' is a change in performance of -0.63% (stdev: 1.44%).

... origin/main ssoelvsten/adiar/internal/quantify/pred-profile
Mean 5170.75 5203.25
Standard Deviation 74.10 75.09

Number of samples: 4

Copy link

github-actions bot commented Apr 30, 2024

🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/internal/quantify/pred-profile' is a change in performance of -0.73% (stdev: 1.65%).

... origin/main ssoelvsten/adiar/internal/quantify/pred-profile
Mean 9447.00 9515.50
Standard Deviation 72.59 157.10

Number of samples: 4

Copy link

github-actions bot commented Apr 30, 2024

🟢 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/internal/quantify/pred-profile' is a change in performance of 2.63% (stdev: 4.48%).

... origin/main ssoelvsten/adiar/internal/quantify/pred-profile
Mean 5180.50 5044.25
Standard Deviation 232.29 50.61

Number of samples: 4

This comment was marked as off-topic.

Copy link

github-actions bot commented Apr 30, 2024

🟢 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/internal/quantify/pred-profile' is a change in performance of 0.53% (stdev: 0.53%).

... origin/main ssoelvsten/adiar/internal/quantify/pred-profile
Mean 12063.75 12000.25
Standard Deviation 64.02 49.12

Number of samples: 4

Copy link

github-actions bot commented Apr 30, 2024

🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/internal/quantify/pred-profile' is a change in performance of -0.36% (stdev: 0.50%).

... origin/main ssoelvsten/adiar/internal/quantify/pred-profile
Mean 15392.00 15446.67
Standard Deviation 76.49 65.90

Number of samples: 3

Copy link

github-actions bot commented Apr 30, 2024

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/internal/quantify/pred-profile' is a change in performance of 0.84% (stdev: 0.97%).

... origin/main ssoelvsten/adiar/internal/quantify/pred-profile
Mean 22031.33 21847.33
Standard Deviation 214.49 30.53

Number of samples: 3

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@SSoelvsten SSoelvsten force-pushed the internal/quantify/pred-profile branch from cc6a9e8 to 91490c7 Compare May 2, 2024 08:15
SSoelvsten added 6 commits May 2, 2024 10:38
Compared to using 'seen_widest' in the previous commit, this better encapsulate a diamond-shaped but
BDD that gets wide early. The 'deep' variables are then symmetrically only the ones as deep as the
ones at the top (measured in number of nodes, not number of levels).
@SSoelvsten SSoelvsten force-pushed the internal/quantify/pred-profile branch from 91490c7 to 6f272c3 Compare May 2, 2024 08:38
@SSoelvsten SSoelvsten merged commit 7f98714 into main May 7, 2024
58 of 60 checks passed
@SSoelvsten SSoelvsten deleted the internal/quantify/pred-profile branch May 7, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ code quality Uncle Bob would be proud ✨ optimisation It's all about speed / space
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant