Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/quantify/restrict pruning #656

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Apr 22, 2024

As a follow-up on #655 , we'll try to decrease the constant in the initial transposition by using the Select algorithm instead of the extended Quantification algorithm.

Either way, the first two commits ought to be merged.

@SSoelvsten SSoelvsten added the ✨ optimisation It's all about speed / space label Apr 22, 2024
@SSoelvsten SSoelvsten self-assigned this Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 99.16667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.371%. Comparing base (9935913) to head (7646c5d).

Files Patch % Lines
src/adiar/internal/algorithms/select.h 97.059% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main      #656       +/-   ##
=============================================
+ Coverage   97.331%   97.371%   +0.040%     
=============================================
  Files           90        90               
  Lines         6520      6505       -15     
=============================================
- Hits          6346      6334       -12     
+ Misses         174       171        -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 22, 2024

🟢 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'origin/internal/quantify/restrict-pruning' is a change in performance of 2.53% (stdev: 0.52%).

... origin/main origin/internal/quantify/restrict-pruning
Mean 12383.12 12069.75
Standard Deviation 64.30 49.48

Number of samples: 8

Copy link

github-actions bot commented Apr 22, 2024

🟢 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'origin/internal/quantify/restrict-pruning' is a change in performance of 0.06% (stdev: 0.86%).

... origin/main origin/internal/quantify/restrict-pruning
Mean 5077.25 5074.12
Standard Deviation 39.91 43.41

Number of samples: 8

Copy link

github-actions bot commented Apr 22, 2024

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/internal/quantify/restrict-pruning' is a change in performance of -0.70% (stdev: 1.00%).

... origin/main origin/internal/quantify/restrict-pruning
Mean 29850.00 30059.33
Standard Deviation 298.04 180.66

Number of samples: 6

This comment was marked as off-topic.

Copy link

github-actions bot commented Apr 22, 2024

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/internal/quantify/restrict-pruning' is a change in performance of 8.21% (stdev: 0.76%).

... origin/main origin/internal/quantify/restrict-pruning
Mean 16687.29 15317.86
Standard Deviation 72.97 117.04

Number of samples: 7

Copy link

github-actions bot commented Apr 22, 2024

🟢 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'origin/internal/quantify/restrict-pruning' is a change in performance of 4.94% (stdev: 1.11%).

... origin/main origin/internal/quantify/restrict-pruning
Mean 18091.57 17198.71
Standard Deviation 200.41 93.57

Number of samples: 7

This comment was marked as off-topic.

Copy link

github-actions bot commented Apr 22, 2024

🟢 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'origin/internal/quantify/restrict-pruning' is a change in performance of 5.54% (stdev: 1.34%).

... origin/main origin/internal/quantify/restrict-pruning
Mean 9980.12 9427.25
Standard Deviation 26.34 126.78

Number of samples: 8

Copy link

github-actions bot commented Apr 22, 2024

🟢 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'origin/internal/quantify/restrict-pruning' is a change in performance of 2.77% (stdev: 0.77%).

... origin/main origin/internal/quantify/restrict-pruning
Mean 5400.50 5251.00
Standard Deviation 41.78 38.98

Number of samples: 8

Copy link

github-actions bot commented Apr 22, 2024

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/internal/quantify/restrict-pruning' is a change in performance of 11.04% (stdev: 0.71%).

... origin/main origin/internal/quantify/restrict-pruning
Mean 24963.86 22206.86
Standard Deviation 69.89 157.49

Number of samples: 7

@SSoelvsten SSoelvsten marked this pull request as ready for review April 22, 2024 12:50
Copy link

🟡 Regression Test (Picotrav 'arbiter')

'origin/internal/quantify/restrict-pruning' is a change in performance of -0.07% (stdev: 0.63%).

... origin/main origin/internal/quantify/restrict-pruning
Mean 63891.40 63936.00
Standard Deviation 315.72 404.68

Number of samples: 5

This comment was marked as off-topic.

This comment was marked as off-topic.

@SSoelvsten SSoelvsten merged commit f409f0f into main Apr 23, 2024
61 of 62 checks passed
@SSoelvsten SSoelvsten deleted the internal/quantify/restrict-pruning branch April 23, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ optimisation It's all about speed / space
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant