Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terminal pruning for initial transposition sweep #653

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Apr 18, 2024

Closes #652 ; the code is feels slightly hacky/ugly. But, it seems more a sign of a deeper problem that ought to be fixed.

@SSoelvsten SSoelvsten added the ✨ optimisation It's all about speed / space label Apr 18, 2024
@SSoelvsten SSoelvsten self-assigned this Apr 18, 2024

This comment was marked as resolved.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.331%. Comparing base (52a74f3) to head (21a93a0).

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #653       +/-   ##
=============================================
+ Coverage   97.311%   97.331%   +0.020%     
=============================================
  Files           90        90               
  Lines         6471      6520       +49     
=============================================
+ Hits          6297      6346       +49     
  Misses         174       174               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SSoelvsten SSoelvsten force-pushed the quantify/pruning-quantification branch from ab2832b to b6b5783 Compare April 18, 2024 07:39

This comment was marked as off-topic.

Copy link

github-actions bot commented Apr 18, 2024

🟢 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'origin/quantify/pruning-quantification' is a change in performance of 9.78% (stdev: 0.96%).

... origin/main origin/quantify/pruning-quantification
Mean 19719.62 17790.38
Standard Deviation 190.02 87.21

Number of samples: 8

Copy link

github-actions bot commented Apr 18, 2024

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'origin/quantify/pruning-quantification' is a change in performance of -0.22% (stdev: 0.69%).

... origin/main origin/quantify/pruning-quantification
Mean 12389.22 12416.44
Standard Deviation 78.89 86.19

Number of samples: 9

Copy link

github-actions bot commented Apr 18, 2024

🟢 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'origin/quantify/pruning-quantification' is a change in performance of 0.24% (stdev: 0.88%).

... origin/main origin/quantify/pruning-quantification
Mean 5362.67 5350.00
Standard Deviation 43.97 47.06

Number of samples: 9

This comment was marked as off-topic.

Copy link

github-actions bot commented Apr 18, 2024

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/quantify/pruning-quantification' is a change in performance of 18.68% (stdev: 0.80%).

... origin/main origin/quantify/pruning-quantification
Mean 20718.57 16848.43
Standard Deviation 165.24 114.54

Number of samples: 7

Copy link

github-actions bot commented Apr 18, 2024

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/quantify/pruning-quantification' is a change in performance of -0.18% (stdev: 0.72%).

... origin/main origin/quantify/pruning-quantification
Mean 29524.43 29576.57
Standard Deviation 182.18 213.10

Number of samples: 7

This comment was marked as off-topic.

Copy link

github-actions bot commented Apr 18, 2024

🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'origin/quantify/pruning-quantification' is a change in performance of -2.34% (stdev: 3.93%).

... origin/main origin/quantify/pruning-quantification
Mean 5034.40 5152.20
Standard Deviation 26.90 202.34

Number of samples: 10

Copy link

github-actions bot commented Apr 18, 2024

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/quantify/pruning-quantification' is a change in performance of -0.52% (stdev: 0.70%).

... origin/main origin/quantify/pruning-quantification
Mean 25038.57 25167.57
Standard Deviation 176.34 55.72

Number of samples: 7

This comment was marked as off-topic.

Copy link

github-actions bot commented Apr 18, 2024

🟢 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'origin/quantify/pruning-quantification' is a change in performance of 6.47% (stdev: 0.73%).

... origin/main origin/quantify/pruning-quantification
Mean 11003.88 10292.00
Standard Deviation 79.17 74.84

Number of samples: 8

This comment was marked as off-topic.

@SSoelvsten SSoelvsten force-pushed the quantify/pruning-quantification branch 2 times, most recently from 17c49e3 to 7503afe Compare April 18, 2024 12:46
@SSoelvsten SSoelvsten force-pushed the quantify/pruning-quantification branch from 7503afe to 1f68d23 Compare April 18, 2024 12:50
@SSoelvsten SSoelvsten force-pushed the quantify/pruning-quantification branch from 1f68d23 to 21a93a0 Compare April 18, 2024 12:51
@SSoelvsten SSoelvsten changed the title Add terminal pruning for initial transposition sweep (WIP) Add terminal pruning for initial transposition sweep Apr 19, 2024
@SSoelvsten SSoelvsten marked this pull request as ready for review April 19, 2024 07:39
@SSoelvsten SSoelvsten merged commit 9935913 into main Apr 19, 2024
62 checks passed
@SSoelvsten SSoelvsten deleted the quantify/pruning-quantification branch April 19, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ optimisation It's all about speed / space
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add True-pruning to Transposing Single-variable Quantification Sweep with Predicates
1 participant