Internal/quantify/terminal heuristic (3) #647
Conversation
Our heuristics are not good enough to properly differentiate between using Partial Sweeping or not. Better is to just disable this feature by default.
It seems like this heuristic is not good enough at differentiating between cases that should use one or more partial sweeps and those that should not. If anything, it might only be a bad proxy for some other meta information that we should use instead. Hence, we better remove it to not have semi-dead and untested code laying around in the codebase
SSoelvsten
added
✨ feature
SSoelvsten
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
=============================================
- Coverage 97.315% 97.309% -0.005%
=============================================
Files 90 90
Lines 6480 6467 -13
=============================================
- Hits 6306 6293 -13
Misses 174 174 ☔ View full report in Codecov by Sentry. |
This comment was marked as off-topic.
This comment was marked as off-topic.
🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')'origin/internal/quantify/terminal_heuristic__3' is a change in performance of 11.76% (stdev: 0.57%).
Number of samples: 3 |
🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')'origin/internal/quantify/terminal_heuristic__3' is a change in performance of 1.79% (stdev: 0.76%).
Number of samples: 3 |
🔴 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')'origin/internal/quantify/terminal_heuristic__3' is a change in performance of -154.89% (stdev: 1.50%).
Number of samples: 3 |
🟢 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')'origin/internal/quantify/terminal_heuristic__3' is a change in performance of 53.67% (stdev: 0.87%).
Number of samples: 3 |
🟢 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')'origin/internal/quantify/terminal_heuristic__3' is a change in performance of 37.83% (stdev: 0.71%).
Number of samples: 3 |
🔴 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')'origin/internal/quantify/terminal_heuristic__3' is a change in performance of -50.61% (stdev: 1.05%).
Number of samples: 4 |
This comment was marked as off-topic.
This comment was marked as off-topic.
🟢 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')'origin/internal/quantify/terminal_heuristic__3' is a change in performance of 25.99% (stdev: 0.55%).
Number of samples: 4 |
🔴 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')'origin/internal/quantify/terminal_heuristic__3' is a change in performance of -18.77% (stdev: 0.90%).
Number of samples: 4 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Disables Partial Sweeping and Repeated Transposition by default. Furthermore, it also removes the Terminal Count heuristic since it did not seem to be working or explainable.