Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings on 'signed vs. unsigned' when compiling with statistics #638

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

SSoelvsten
Copy link
Owner

No description provided.

@SSoelvsten SSoelvsten added the 📁 build CMake, GitHub Actions etc. label Mar 12, 2024
@SSoelvsten SSoelvsten self-assigned this Mar 12, 2024
@SSoelvsten SSoelvsten force-pushed the internal/quantify/signed-warning branch from 631a077 to 26433b4 Compare March 12, 2024 08:19
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.306%. Comparing base (5ac21d0) to head (26433b4).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #638   +/-   ##
=========================================
  Coverage   97.306%   97.306%           
=========================================
  Files           90        90           
  Lines         6534      6534           
=========================================
  Hits          6358      6358           
  Misses         176       176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🟢 Regression Test (12-Queens)

'origin/internal/quantify/signed-warning' is a change in performance of 0.02% (stdev: 0.65%).

... origin/main origin/internal/quantify/signed-warning
Mean 11661.88 11659.75
Standard Deviation 66.79 75.23

Number of samples: 8

Copy link

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/internal/quantify/signed-warning' is a change in performance of 0.50% (stdev: 1.69%).

... origin/main origin/internal/quantify/signed-warning
Mean 23856.29 23736.57
Standard Deviation 402.55 345.58

Number of samples: 7

Copy link

🟡 Regression Test (Picotrav 'mem_ctrl')

'origin/internal/quantify/signed-warning' is a change in performance of -0.46% (stdev: 0.49%).

... origin/main origin/internal/quantify/signed-warning
Mean 111961.67 112472.67
Standard Deviation 520.23 553.12

Number of samples: 3

Copy link

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/internal/quantify/signed-warning' is a change in performance of 0.30% (stdev: 0.44%).

... origin/main origin/internal/quantify/signed-warning
Mean 23204.71 23134.00
Standard Deviation 77.54 102.28

Number of samples: 7

Copy link

🔴 Regression Test (Picotrav 'arbiter')

'origin/internal/quantify/signed-warning' is a change in performance of -0.59% (stdev: 0.31%).

... origin/main origin/internal/quantify/signed-warning
Mean 62676.60 63049.00
Standard Deviation 192.72 164.06

Number of samples: 5

Copy link

🟡 Regression Test (QBF 'breakthrough/3x5_11_bwnib')

'origin/internal/quantify/signed-warning' is a change in performance of -0.17% (stdev: 0.60%).

... origin/main origin/internal/quantify/signed-warning
Mean 7420.78 7433.22
Standard Deviation 44.85 44.15

Number of samples: 9

Copy link

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/internal/quantify/signed-warning' is a change in performance of 0.04% (stdev: 1.06%).

... origin/main origin/internal/quantify/signed-warning
Mean 11550.62 11545.75
Standard Deviation 47.34 122.65

Number of samples: 8

Copy link

🟢 Regression Test (Picotrav 'adder')

'origin/internal/quantify/signed-warning' is a change in performance of 0.27% (stdev: 9.11%).

... origin/main origin/internal/quantify/signed-warning
Mean 9494.30 9468.80
Standard Deviation 864.86 826.73

Number of samples: 10

@SSoelvsten SSoelvsten merged commit 73046c8 into main Mar 12, 2024
49 of 56 checks passed
@SSoelvsten SSoelvsten deleted the internal/quantify/signed-warning branch March 12, 2024 09:15
Copy link

🟡 Regression Test (14-Queens)

'origin/internal/quantify/signed-warning' is a change in performance of -0.15% (stdev: 0.59%).

... origin/main origin/internal/quantify/signed-warning
Mean 270930.00 271339.33
Standard Deviation 1593.99 497.43

Number of samples: 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 build CMake, GitHub Actions etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant